Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2656323002: [Content suggestions] Never update snippets after FetchMore (Closed)

Created:
3 years, 10 months ago by jkrcal
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Content suggestions] Never update snippets after FetchMore The new logic for replacing snippets does not work well for the case after more suggestions are fetched by the provider on demand and appended to the list. This CL switches off replacing the snippets after any snippets have been appended. BUG=683050 Review-Url: https://codereview.chromium.org/2644143003 Cr-Commit-Position: refs/heads/master@{#446005} (cherry picked from commit 389bba160bee7a83f0fd3b0227b6757dc8ae3e77) Review-Url: https://codereview.chromium.org/2656323002 . Cr-Commit-Position: refs/branch-heads/2987@{#139} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/948a7f73e91c84ef7bf4f9921887a39a11fbb20f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -43 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java View 19 chunks +77 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkrcal
3 years, 10 months ago (2017-01-27 09:49:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
948a7f73e91c84ef7bf4f9921887a39a11fbb20f.

Powered by Google App Engine
This is Rietveld 408576698