Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2656303006: Remove Scopevector in //components/sync/ (Closed)

Created:
3 years, 10 months ago by ke.he
Modified:
3 years, 10 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Scopevector in //components/sync/ BUG=554289 Review-Url: https://codereview.chromium.org/2656303006 Cr-Commit-Position: refs/heads/master@{#446987} Committed: https://chromium.googlesource.com/chromium/src/+/90a0232e3b790a6b80c6411bbdaeea3338df5e6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M components/sync/engine_impl/cycle/data_type_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/cycle/data_type_tracker.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M components/sync/test/engine/mock_connection_manager.h View 3 chunks +8 lines, -7 lines 0 comments Download
M components/sync/test/engine/mock_connection_manager.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ke.he
Hi, maxbogue@, could you PTAL on this. Thanks.
3 years, 10 months ago (2017-01-28 08:58:22 UTC) #6
maxbogue
lgtm
3 years, 10 months ago (2017-01-30 13:07:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656303006/1
3 years, 10 months ago (2017-01-30 14:20:27 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 15:43:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90a0232e3b790a6b80c6411bbdae...

Powered by Google App Engine
This is Rietveld 408576698