Find Favicon in priority of icon_type.

chrome/browser/favicon/favicon_service.h

Index: chrome/browser/favicon/favicon_service.h
diff --git a/chrome/browser/favicon/favicon_service.h b/chrome/browser/favicon/favicon_service.h
index 692a6ebe74e1d570670da09befcfc51ec8658a50..5df8c61276eebf94e5e22f871472ff5d1c984d00 100644
--- a/chrome/browser/favicon/favicon_service.h
+++ b/chrome/browser/favicon/favicon_service.h
@@ -172,6 +172,15 @@ class FaviconService : public CancelableRequestProvider,
       const FaviconRawCallback& callback,
       CancelableTaskTracker* tracker);
 
+  // See history::HistoryService::GetLargestFaviconForURL.
+  CancelableTaskTracker::TaskId GetLargestRawFaviconForURL(
+      Profile* profile,

[sky, 2013/10/15 15:03:47]

Why do we need the profile here? Doesn't FaviconService have a way to know the
Profile?

[michaelbai, 2013/10/15 19:36:31]

Currently, it seemed that FaviconService are not supposed to get Profile by
itself, the Profile is passed in in FaviconForURLParams, the HistoryService
which only needs the profile to construct is also passed in.

On 2013/10/15 15:03:47, sky wrote:

[sky, 2013/10/16 13:27:15]

I don't think there is a good reason for this. Make FaviconService take the
Profile in its constructor and remove Profile from this method and others. If
that change is too big, do it in a separate patch first.

[michaelbai, 2013/10/16 18:17:05]

I will do it in separated patch. https://crbug/308153

On 2013/10/16 13:27:15, sky wrote:

+      const GURL& page_url,
+      const std::vector<int>& icon_types,
+      int minimal_size_in_pixel,

[sky, 2013/10/15 15:03:47]

minimum_size_in_pixels here and everywhere.

[michaelbai, 2013/10/15 19:36:31]

Done.

+      const FaviconRawCallback& callback,
+      CancelableTaskTracker* tracker);
+
   CancelableTaskTracker::TaskId GetFaviconForURL(
       const FaviconForURLParams& params,
       const FaviconResultsCallback& callback,
@@ -246,6 +255,14 @@ class FaviconService : public CancelableRequestProvider,
       const FaviconResultsCallback& callback,
       CancelableTaskTracker* tracker);
 
+  CancelableTaskTracker::TaskId GetLargestRawFaviconForURLImpl(
+      Profile* profile,
+      const GURL& page_url,
+      const std::vector<int>& icon_types,
+      int minimal_size_in_pixel,
+      const FaviconResultsCallback& callback,
+      CancelableTaskTracker* tracker);
+
   // Intermediate callback for GetFaviconImage() and GetFaviconImageForURL()
   // so that history service can deal solely with FaviconResultsCallback.
   // Builds chrome::FaviconImageResult from |favicon_bitmap_results| and runs