Find Favicon in priority of icon_type.

chrome/browser/favicon/favicon_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 154 matching lines @@
       const FaviconForURLParams& params,
       const FaviconImageCallback& callback,
       CancelableTaskTracker* tracker);
 
   CancelableTaskTracker::TaskId GetRawFaviconForURL(
       const FaviconForURLParams& params,
       ui::ScaleFactor desired_scale_factor,
       const FaviconRawCallback& callback,
       CancelableTaskTracker* tracker);
 
+  // See history::HistoryService::GetLargestFaviconForURL.
+  CancelableTaskTracker::TaskId GetLargestRawFaviconForURL(
+      Profile* profile,

[sky, 2013/10/15 15:03:47]

Why do we need the profile here? Doesn't FaviconService have a way to know the
Profile?

[michaelbai, 2013/10/15 19:36:31]

Currently, it seemed that FaviconService are not supposed to get Profile by
itself, the Profile is passed in in FaviconForURLParams, the HistoryService
which only needs the profile to construct is also passed in.

On 2013/10/15 15:03:47, sky wrote:

[sky, 2013/10/16 13:27:15]

I don't think there is a good reason for this. Make FaviconService take the
Profile in its constructor and remove Profile from this method and others. If
that change is too big, do it in a separate patch first.

[michaelbai, 2013/10/16 18:17:05]

I will do it in separated patch. https://crbug/308153

On 2013/10/16 13:27:15, sky wrote:

+      const GURL& page_url,
+      const std::vector<int>& icon_types,
+      int minimal_size_in_pixel,

[sky, 2013/10/15 15:03:47]

minimum_size_in_pixels here and everywhere.

[michaelbai, 2013/10/15 19:36:31]

Done.

+      const FaviconRawCallback& callback,
+      CancelableTaskTracker* tracker);
+
   CancelableTaskTracker::TaskId GetFaviconForURL(
       const FaviconForURLParams& params,
       const FaviconResultsCallback& callback,
       CancelableTaskTracker* tracker);
 
   // Used to request a bitmap for the favicon with |favicon_id| which is not
   // resized from the size it is stored at in the database. If there are
   // multiple favicon bitmaps for |favicon_id|, the largest favicon bitmap is
   // returned.
   CancelableTaskTracker::TaskId GetLargestRawFaviconForID(
@@ skipping 54 matching lines @@
   HistoryService* history_service_;
 
   // Helper function for GetFaviconImageForURL(), GetRawFaviconForURL() and
   // GetFaviconForURL().
   CancelableTaskTracker::TaskId GetFaviconForURLImpl(
       const FaviconForURLParams& params,
       const std::vector<ui::ScaleFactor>& desired_scale_factors,
       const FaviconResultsCallback& callback,
       CancelableTaskTracker* tracker);
 
+  CancelableTaskTracker::TaskId GetLargestRawFaviconForURLImpl(
+      Profile* profile,
+      const GURL& page_url,
+      const std::vector<int>& icon_types,
+      int minimal_size_in_pixel,
+      const FaviconResultsCallback& callback,
+      CancelableTaskTracker* tracker);
+
   // Intermediate callback for GetFaviconImage() and GetFaviconImageForURL()
   // so that history service can deal solely with FaviconResultsCallback.
   // Builds chrome::FaviconImageResult from |favicon_bitmap_results| and runs
   // |callback|.
   void RunFaviconImageCallbackWithBitmapResults(
       const FaviconImageCallback& callback,
       int desired_size_in_dip,
       const std::vector<chrome::FaviconBitmapResult>& favicon_bitmap_results);
 
   // Intermediate callback for GetRawFavicon() and GetRawFaviconForURL()
   // so that history service can deal solely with FaviconResultsCallback.
   // Resizes chrome::FaviconBitmapResult if necessary and runs |callback|.
   void RunFaviconRawCallbackWithBitmapResults(
       const FaviconRawCallback& callback,
       int desired_size_in_dip,
       ui::ScaleFactor desired_scale_factor,
       const std::vector<chrome::FaviconBitmapResult>& favicon_bitmap_results);
 
   DISALLOW_COPY_AND_ASSIGN(FaviconService);
 };
 
 #endif  // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_