Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2656273003: Detect/report animations that are cancelled after they start. (Closed)

Created:
3 years, 10 months ago by smcgruer
Modified:
3 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, flackr, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Detect/report animations that are cancelled after they start. Previously, we were early-exiting from |animationPlayStateChange| if an animation was contained in |m_idToAnimation|. However, this means that we miss cancel events for animations that have already been started, since the 'start' event causes them to be placed in |m_idToAnimation|. BUG=686091 Review-Url: https://codereview.chromium.org/2656273003 Cr-Commit-Position: refs/heads/master@{#447074} Committed: https://chromium.googlesource.com/chromium/src/+/e04864cab7755bdc01abf0431cfd825d488b309c

Patch Set 1 #

Patch Set 2 : Slight comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-start-cancel.html View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-start-cancel-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
smcgruer
3 years, 10 months ago (2017-01-27 15:15:26 UTC) #4
kozy
lgtm, thanks. Added Dmitry since I'm not an owner of this file.
3 years, 10 months ago (2017-01-30 17:22:31 UTC) #8
dgozman
lgtm
3 years, 10 months ago (2017-01-30 17:31:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656273003/20001
3 years, 10 months ago (2017-01-30 17:32:34 UTC) #11
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 10 months ago (2017-01-30 19:58:32 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 21:39:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e04864cab7755bdc01abf0431cfd...

Powered by Google App Engine
This is Rietveld 408576698