Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2656223002: Update static_initializers tool to build easier, find more (Closed)

Created:
3 years, 11 months ago by brucedawson
Modified:
3 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update static_initializers tool to build easier, find more static_initializers failed to find the initializer/destructor code for g_fallback_crash_handler_launcher because it was of this form: `dynamic atexit destructor for ' So, this pattern is now watched for. This change also adds a build.bat file and .gitignore file. If we add this to the bots we'll need to make it part of the .gn build. R=scottmg@chromium.org BUG=677351 Review-Url: https://codereview.chromium.org/2656223002 Cr-Commit-Position: refs/heads/master@{#446524} Committed: https://chromium.googlesource.com/chromium/src/+/4419391c9bd15c97e01fcacbf40871344476b5ca

Patch Set 1 #

Patch Set 2 : Add +x attribute to build.bat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A tools/win/static_initializers/.gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/win/static_initializers/build.bat View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/win/static_initializers/static_initializers.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
brucedawson
PTAL. Adding it to the .gn build would be good also but I didn't feel ...
3 years, 11 months ago (2017-01-26 22:30:11 UTC) #1
scottmg
lgtm
3 years, 11 months ago (2017-01-26 22:31:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656223002/1
3 years, 11 months ago (2017-01-26 22:40:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/351489)
3 years, 11 months ago (2017-01-26 22:56:21 UTC) #6
scottmg
On 2017/01/26 22:56:21, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-26 23:03:41 UTC) #7
brucedawson
On 2017/01/26 23:03:41, scottmg wrote: > On 2017/01/26 22:56:21, commit-bot: I haz the power wrote: ...
3 years, 11 months ago (2017-01-27 01:07:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656223002/20001
3 years, 11 months ago (2017-01-27 01:08:39 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 01:31:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4419391c9bd15c97e01fcacbf408...

Powered by Google App Engine
This is Rietveld 408576698