Makes SessionCrashedBubbleView work on chromeos

Makes SessionCrashedBubbleView work on chromeos

I've also made SessionCrashedInfoBarDelege only compiled on mac
non-views.

BUG=653966
TEST=none
R=yiyaoliu@chromium.org

Review-Url: https://codereview.chromium.org/2656213002
Cr-Commit-Position: refs/heads/master@{#446787}
Committed: https://chromium.googlesource.com/chromium/src/+/744a55eb6a5bdcff9158ebc73814c41263e07223

[sky, 2017-01-26 22:15:50]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:16:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 22:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 22:31:45]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-01-26 22:38:22]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:39:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-26 23:33:14]

The CQ bit was unchecked by sky@chromium.org

[yao, 2017-01-26 23:35:08]

Description was changed from

==========
Makes SessionCrashedBubbleView work on chromeos

I've also made SessionCrashedInfoBarDelege only compiled on mac
non-views.

BUG=653966
TEST=none
R=yiyaoliu@chromium.org
==========

to

==========
Makes SessionCrashedBubbleView work on chromeos

I've also made SessionCrashedInfoBarDelege only compiled on mac
non-views.

BUG=653966
TEST=none
R=yiyaoliu@chromium.org
==========

[yao, 2017-01-26 23:35:08]

yiyaoliu@chromium.org changed reviewers:
+ asvitkine@chromium.org
- yiyaoliu@chromium.org

[Alexei Svitkine (slow), 2017-01-27 17:27:12]

lgtm % comment

https://codereview.chromium.org/2656213002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/2656213002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:75: #if
defined(GOOGLE_CHROME_BUILD) && !defined(OS_CHROMEOS)
As I said in the email, I think the consent stuff should work on CrOS now too -
so I think we can just enable this there too and remove this extra helper.

[sky, 2017-01-27 18:25:04]

Take another look?

https://codereview.chromium.org/2656213002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/2656213002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:75: #if
defined(GOOGLE_CHROME_BUILD) && !defined(OS_CHROMEOS)
On 2017/01/27 17:27:11, Alexei Svitkine (slow) wrote:
> As I said in the email, I think the consent stuff should work on CrOS now too
-
> so I think we can just enable this there too and remove this extra helper.

I clearly misunderstood your email. I removed chromeos from the conditional.

[sky, 2017-01-27 18:25:15]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 18:25:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-27 18:28:59]

lgtm

[sky, 2017-01-27 18:29:26]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-01-27 18:29:30]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:29:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 20:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:35:08]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sky, 2017-01-27 21:08:14]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-01-27 21:08:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 22:12:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485551294043940,
"parent_rev": "83f6eb987cec5368ded0af78dc11c23793d271fb", "commit_rev":
"744a55eb6a5bdcff9158ebc73814c41263e07223"}

[commit-bot: I haz the power, 2017-01-27 22:12:58]

Description was changed from

==========
Makes SessionCrashedBubbleView work on chromeos

I've also made SessionCrashedInfoBarDelege only compiled on mac
non-views.

BUG=653966
TEST=none
R=yiyaoliu@chromium.org
==========

to

==========
Makes SessionCrashedBubbleView work on chromeos

I've also made SessionCrashedInfoBarDelege only compiled on mac
non-views.

BUG=653966
TEST=none
R=yiyaoliu@chromium.org

Review-Url: https://codereview.chromium.org/2656213002
Cr-Commit-Position: refs/heads/master@{#446787}
Committed:
https://chromium.googlesource.com/chromium/src/+/744a55eb6a5bdcff9158ebc73814...
==========

[commit-bot: I haz the power, 2017-01-27 22:13:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/744a55eb6a5bdcff9158ebc73814...