Convert RuntimeEnabledFeatures.in config file to JSON format.

Convert RuntimeEnabledFeatures.in config file to JSON5 format.

The allowed parameters and their default and valid values/types are
now in the config file itself rather than in separate .py script.

Added comments for parameters "feature_policy" and "custom".
And removed obsolete "condition" parameter.

BUG=677884
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2656163005
Cr-Commit-Position: refs/heads/master@{#449191}
Committed: https://chromium.googlesource.com/chromium/src/+/5821741047894731b6527b607edfb8ddef33fd1b

[ktyliu, 2017-01-27 05:04:42]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 05:05:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-27 05:18:31]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 05:18:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 07:31:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 07:31:21]

Dry run: This issue passed the CQ dry run.

[ktyliu, 2017-01-27 07:37:09]

Description was changed from

==========
Convert RuntimeEnabledFeatures.in config file to JSON format.

BUG=677884
==========

to

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

BUG=677884
==========

[ktyliu, 2017-01-27 07:38:02]

ktyliu@chromium.org changed reviewers:
+ rbyers@chromium.org

[ktyliu, 2017-01-27 07:38:02]

Hi Rick,

Are you okay to help approve this change of using JSON5 format for
RuntimeEnabledFeatures?

Thanks,
Kevin

[Rick Byers, 2017-01-27 22:17:02]

Looks reasonable, thanks for doing this!  Just a couple questions / concerns.

I obviously didn't mechanically verify that you found all the places or that the
new file exactly matches the old (did you use a script or manual process to
convert it?).  But most types of mistakes would be caught by tests (eg.
virtual/stable/webexposed/*) so I'm not too worried about it.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:101: runtime_enabled_features_in =
"RuntimeEnabledFeatures.json5"
nit: rename this variable to match the new filename too?

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:102: inputs = scripts_for_in_files +
[
this scripts_for_in_files should change too, right?  Eg. instead of
in_generator.py it should depend on json5_generator.py.  Looks like the
settings.json5 rules are missing this too.  So if someone changes the
json5_generator code, I think these won't be detected as needing rebuild.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:52: condition: {
what are these three?  They don't appear to be used below or mentioned anywhere
in the original .in file.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:142:
"CompositedSelectionUpdate",
are bare strings allowed here?  I assume this is identical to:
{
  name: "CompositedSelectionUpdate",
}

right?

Personally I have a preference for the more verbose syntax to keep everything
regular and make adding/removing a status a smaller change.  But it's not a big
deal if you feel mixing the two styles is better.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:496: //
MediaSession is enabled by default on Android only.
nit: I'd find this a little more readable if the comments for an entry were
inside the block for that entry instead of above it.  Thoughts?

[mlamouri (slow - plz ping), 2017-01-28 01:10:43]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-01-28 01:10:44]

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:496: //
MediaSession is enabled by default on Android only.
On 2017/01/27 at 22:17:01, Rick Byers wrote:
> nit: I'd find this a little more readable if the comments for an entry were
inside the block for that entry instead of above it.  Thoughts?

```
{ // MediaSession is enabled by default on Android only.
  name: "Media Session",
  status: "test",
}
```

maybe? Though, there would be benefit in having consistency across json5.
Probably more important than what looks good here.

[ktyliu, 2017-01-29 21:19:24]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 21:19:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-29 21:22:15]

Thanks for the thorough review and good comments.

The .in -> .json5 conversion is done by a script, so it preserves all entries
and comments.
I also keep a backup copy of RuntimeEnabledFeatures.in around so that when the
file has been modified I can easily use diff to identify what has changed and
apply the change manually.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:101: runtime_enabled_features_in =
"RuntimeEnabledFeatures.json5"
On 2017/01/27 at 22:17:01, Rick Byers wrote:
> nit: rename this variable to match the new filename too?

Done

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:102: inputs = scripts_for_in_files +
[
On 2017/01/27 at 22:17:01, Rick Byers wrote:
> this scripts_for_in_files should change too, right?  Eg. instead of
in_generator.py it should depend on json5_generator.py.  Looks like the
settings.json5 rules are missing this too.  So if someone changes the
json5_generator code, I think these won't be detected as needing rebuild.

good catch
added json5_generator.py to scripts_for_in_files

thanks

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:52: condition: {
On 2017/01/27 at 22:17:02, Rick Byers wrote:
> what are these three?  They don't appear to be used below or mentioned
anywhere in the original .in file.

these three are from make_runtime_features.py;
the new json5_generator allows parameter defaults and valid values/types to be
specified in the config file rather than in the external .py script

some of these are referenced in the template, eg
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/build/scripts/...

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:142:
"CompositedSelectionUpdate",
On 2017/01/27 at 22:17:01, Rick Byers wrote:
> are bare strings allowed here?  I assume this is identical to:
> {
>   name: "CompositedSelectionUpdate",
> }
> 
> right?
> 
> Personally I have a preference for the more verbose syntax to keep everything
regular and make adding/removing a status a smaller change.  But it's not a big
deal if you feel mixing the two styles is better.

agree the more verbose syntax is good for consistency and easier to add/remove
status

Fixed throughout

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:496: //
MediaSession is enabled by default on Android only.
On 2017/01/28 at 01:10:44, mlamouri (slow) wrote:
> On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > nit: I'd find this a little more readable if the comments for an entry were
inside the block for that entry instead of above it.  Thoughts?
> 
> ```
> { // MediaSession is enabled by default on Android only.
>   name: "Media Session",
>   status: "test",
> }
> ```
> 
> maybe? Though, there would be benefit in having consistency across json5.
Probably more important than what looks good here.

I have slight preference for comment above the entry, in addition to Mounir's
point:
* comment above entry means it targets the entire entry {...}, whereas comments
inside the block can target a specific key/value pair
* multiline comment doesn't work as well if we do "{ // first line of comment"

for this specific comment, maybe we should define a parameter such as 'platform:
["android"]' rather than using comment only

[commit-bot: I haz the power, 2017-01-29 23:09:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 23:09:55]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-01-31 17:25:40]

mlamouri@chromium.org changed reviewers:
- mlamouri@chromium.org

[ktyliu, 2017-02-01 04:57:12]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 04:57:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 07:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 07:13:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Rick Byers, 2017-02-06 20:46:24]

Sorry for the delay (was travelling for BlinkOn etc.).  Looks good except for
the one outstanding issue around scripts_for_in_files.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:102: inputs = scripts_for_in_files +
[
On 2017/01/29 21:22:14, ktyliu wrote:
> On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > this scripts_for_in_files should change too, right?  Eg. instead of
> in_generator.py it should depend on json5_generator.py.  Looks like the
> settings.json5 rules are missing this too.  So if someone changes the
> json5_generator code, I think these won't be detected as needing rebuild.
> 
> good catch
> added json5_generator.py to scripts_for_in_files
> 
> thanks

Where is this?  Did you forget to add build/scripts/scripts.gni to your CL?

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:52: condition: {
On 2017/01/29 21:22:14, ktyliu wrote:
> On 2017/01/27 at 22:17:02, Rick Byers wrote:
> > what are these three?  They don't appear to be used below or mentioned
> anywhere in the original .in file.
> 
> these three are from make_runtime_features.py;
> the new json5_generator allows parameter defaults and valid values/types to be
> specified in the config file rather than in the external .py script
> 
> some of these are referenced in the template, eg
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/build/scripts/...

Can you try to add a comment summarizing what they do?  I guess this is a
pre-existing bug that the documentation didn't mention them, but now that you're
forced to mention them it seems we should say SOMETHING.  Worst case and it's
not clear, at least have a comment saying: "Used at ..." to at least help people
trace the code.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:142:
"CompositedSelectionUpdate",
On 2017/01/29 21:22:14, ktyliu wrote:
> On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > are bare strings allowed here?  I assume this is identical to:
> > {
> >   name: "CompositedSelectionUpdate",
> > }
> > 
> > right?
> > 
> > Personally I have a preference for the more verbose syntax to keep
everything
> regular and make adding/removing a status a smaller change.  But it's not a
big
> deal if you feel mixing the two styles is better.
> 
> agree the more verbose syntax is good for consistency and easier to add/remove
> status
> 
> Fixed throughout

Great thanks - definitely looks nicer!

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:496: //
MediaSession is enabled by default on Android only.
On 2017/01/29 21:22:14, ktyliu wrote:
> On 2017/01/28 at 01:10:44, mlamouri (slow) wrote:
> > On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > > nit: I'd find this a little more readable if the comments for an entry
were
> inside the block for that entry instead of above it.  Thoughts?
> > 
> > ```
> > { // MediaSession is enabled by default on Android only.
> >   name: "Media Session",
> >   status: "test",
> > }
> > ```
> > 
> > maybe? Though, there would be benefit in having consistency across json5.
> Probably more important than what looks good here.
> 
> I have slight preference for comment above the entry, in addition to Mounir's
> point:
> * comment above entry means it targets the entire entry {...}, whereas
comments
> inside the block can target a specific key/value pair
> * multiline comment doesn't work as well if we do "{ // first line of comment"

Ok, SGTM
 
> for this specific comment, maybe we should define a parameter such as
'platform:
> ["android"]' rather than using comment only

Yes we totally should add that.  If you can quickly add such a OS-specific
parameter in (I think I saw something similar in another json5 file you worked
on?) that would be awesome.  If you'd rather leave it for someone else, then
I'll add it to my list to try to do sometime after this CL lands.

[ktyliu, 2017-02-07 01:07:40]

On 2017/02/06 at 20:46:24, rbyers wrote:
> Sorry for the delay (was travelling for BlinkOn etc.).  Looks good except for
the one outstanding issue around scripts_for_in_files.
> 
>
https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/BUILD.gn:102: inputs = scripts_for_in_files
+ [
> On 2017/01/29 21:22:14, ktyliu wrote:
> > On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > > this scripts_for_in_files should change too, right?  Eg. instead of
> > in_generator.py it should depend on json5_generator.py.  Looks like the
> > settings.json5 rules are missing this too.  So if someone changes the
> > json5_generator code, I think these won't be detected as needing rebuild.
> > 
> > good catch
> > added json5_generator.py to scripts_for_in_files
> > 
> > thanks
> 
> Where is this?  Did you forget to add build/scripts/scripts.gni to your CL?
> 
>
https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):
> 
>
https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:52: condition:
{
> On 2017/01/29 21:22:14, ktyliu wrote:
> > On 2017/01/27 at 22:17:02, Rick Byers wrote:
> > > what are these three?  They don't appear to be used below or mentioned
> > anywhere in the original .in file.
> > 
> > these three are from make_runtime_features.py;
> > the new json5_generator allows parameter defaults and valid values/types to
be
> > specified in the config file rather than in the external .py script
> > 
> > some of these are referenced in the template, eg
> >
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/build/scripts/...
> 
> Can you try to add a comment summarizing what they do?  I guess this is a
pre-existing bug that the documentation didn't mention them, but now that you're
forced to mention them it seems we should say SOMETHING.  Worst case and it's
not clear, at least have a comment saying: "Used at ..." to at least help people
trace the code.
> 
>
https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:142:
"CompositedSelectionUpdate",
> On 2017/01/29 21:22:14, ktyliu wrote:
> > On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > > are bare strings allowed here?  I assume this is identical to:
> > > {
> > >   name: "CompositedSelectionUpdate",
> > > }
> > > 
> > > right?
> > > 
> > > Personally I have a preference for the more verbose syntax to keep
everything
> > regular and make adding/removing a status a smaller change.  But it's not a
big
> > deal if you feel mixing the two styles is better.
> > 
> > agree the more verbose syntax is good for consistency and easier to
add/remove
> > status
> > 
> > Fixed throughout
> 
> Great thanks - definitely looks nicer!
> 
>
https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:496: //
MediaSession is enabled by default on Android only.
> On 2017/01/29 21:22:14, ktyliu wrote:
> > On 2017/01/28 at 01:10:44, mlamouri (slow) wrote:
> > > On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > > > nit: I'd find this a little more readable if the comments for an entry
were
> > inside the block for that entry instead of above it.  Thoughts?
> > > 
> > > ```
> > > { // MediaSession is enabled by default on Android only.
> > >   name: "Media Session",
> > >   status: "test",
> > > }
> > > ```
> > > 
> > > maybe? Though, there would be benefit in having consistency across json5.
> > Probably more important than what looks good here.
> > 
> > I have slight preference for comment above the entry, in addition to
Mounir's
> > point:
> > * comment above entry means it targets the entire entry {...}, whereas
comments
> > inside the block can target a specific key/value pair
> > * multiline comment doesn't work as well if we do "{ // first line of
comment"
> 
> Ok, SGTM
>  
> > for this specific comment, maybe we should define a parameter such as
'platform:
> > ["android"]' rather than using comment only
> 
> Yes we totally should add that.  If you can quickly add such a OS-specific
parameter in (I think I saw something similar in another json5 file you worked
on?) that would be awesome.  If you'd rather leave it for someone else, then
I'll add it to my list to try to do sometime after this CL lands.

Okay, added a TODO, thanks.
Prefer that it's done in a separate CL so we don't do too many things in one CL.

[ktyliu, 2017-02-07 01:08:17]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 01:09:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-02-07 01:10:03]

Description was changed from

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

BUG=677884
==========

to

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

Default and allowed parameters are now in the config file itself
rather than in separate .py script.

Added comments for parameters feature_policy and custom. And removed
obsolete conditions parameter.

BUG=677884
==========

[ktyliu, 2017-02-07 01:11:29]

Description was changed from

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

Default and allowed parameters are now in the config file itself
rather than in separate .py script.

Added comments for parameters feature_policy and custom. And removed
obsolete conditions parameter.

BUG=677884
==========

to

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

The allowed parameters and their default and valid values/types are
now in the config file itself rather than in separate .py script.

Added comments for parameters "feature_policy" and "custom".
And removed obsolete "condition" parameter.

BUG=677884
==========

[ktyliu, 2017-02-07 01:12:18]

Thanks for the review and comments.
Addressed your comments and updated CL description to cover the scope of change.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:102: inputs = scripts_for_in_files +
[
On 2017/02/06 at 20:46:24, Rick Byers wrote:
> On 2017/01/29 21:22:14, ktyliu wrote:
> > On 2017/01/27 at 22:17:01, Rick Byers wrote:
> > > this scripts_for_in_files should change too, right?  Eg. instead of
> > in_generator.py it should depend on json5_generator.py.  Looks like the
> > settings.json5 rules are missing this too.  So if someone changes the
> > json5_generator code, I think these won't be detected as needing rebuild.
> > 
> > good catch
> > added json5_generator.py to scripts_for_in_files
> > 
> > thanks
> 
> Where is this?  Did you forget to add build/scripts/scripts.gni to your CL?

Done now.

Sorry I had that added in another CL and then I rebased and therefore had no
change. But that CL was later reverted.

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2656163005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:52: condition: {
added comments for feature_policy and custom

conditions seem to be deprecated so I removed it here and in the tmpl.
Specifically
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/Runt...
has
// condition=ENABLE_NAME is used for wrapping features in compile-time
// #if ENABLE(FEATURE) guards.  These are deprecated and should all be removed.

[commit-bot: I haz the power, 2017-02-07 03:02:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 03:02:43]

Dry run: This issue passed the CQ dry run.

[Rick Byers, 2017-02-08 14:25:24]

LGTM, thanks!

[ktyliu, 2017-02-08 22:21:20]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 22:22:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-02-08 22:30:20]

On 2017/02/08 at 14:25:24, rbyers wrote:
> LGTM, thanks!

Thanks!
Rebased and committing now

[ktyliu, 2017-02-08 22:30:24]

The CQ bit was unchecked by ktyliu@chromium.org

[ktyliu, 2017-02-08 22:30:26]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-02-08 22:30:26]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2656163005/#ps100001
(title: "Rebase and add MediaCaptureDepth, MojoJS")

[commit-bot: I haz the power, 2017-02-08 22:31:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 22:40:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ktyliu, 2017-02-09 00:18:31]

ktyliu@chromium.org changed reviewers:
+ jam@chromium.org

[ktyliu, 2017-02-09 00:18:32]

Hi John,

Can you help RSLGTM the change to content/public/common/content_switches.cc ?

Thanks,
Kevin

[Rick Byers, 2017-02-09 01:35:27]

Description was changed from

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

The allowed parameters and their default and valid values/types are
now in the config file itself rather than in separate .py script.

Added comments for parameters "feature_policy" and "custom".
And removed obsolete "condition" parameter.

BUG=677884
==========

to

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

The allowed parameters and their default and valid values/types are
now in the config file itself rather than in separate .py script.

Added comments for parameters "feature_policy" and "custom".
And removed obsolete "condition" parameter.

BUG=677884
TBR=jam@chromium.org
==========

[Rick Byers, 2017-02-09 01:36:28]

On 2017/02/09 00:18:32, ktyliu wrote:
> Hi John,
> 
> Can you help RSLGTM the change to content/public/common/content_switches.cc ?
> 
> Thanks,
> Kevin

It's a trivial comment change, I've TBR'd jam rather than block this on further
review.

[Rick Byers, 2017-02-09 01:36:37]

The CQ bit was checked by rbyers@chromium.org

[commit-bot: I haz the power, 2017-02-09 01:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 02:26:25]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486604197405530,
"parent_rev": "b93cbcadc5af7f922dd3ae2e379d39e06e7c4f93", "commit_rev":
"5821741047894731b6527b607edfb8ddef33fd1b"}

[commit-bot: I haz the power, 2017-02-09 02:27:03]

Description was changed from

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

The allowed parameters and their default and valid values/types are
now in the config file itself rather than in separate .py script.

Added comments for parameters "feature_policy" and "custom".
And removed obsolete "condition" parameter.

BUG=677884
TBR=jam@chromium.org
==========

to

==========
Convert RuntimeEnabledFeatures.in config file to JSON5 format.

The allowed parameters and their default and valid values/types are
now in the config file itself rather than in separate .py script.

Added comments for parameters "feature_policy" and "custom".
And removed obsolete "condition" parameter.

BUG=677884
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2656163005
Cr-Commit-Position: refs/heads/master@{#449191}
Committed:
https://chromium.googlesource.com/chromium/src/+/5821741047894731b6527b607edf...
==========

[commit-bot: I haz the power, 2017-02-09 02:27:08]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5821741047894731b6527b607edf...