Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 2656163004: Convert service_worker_client_utils to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert service_worker_client_utils to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2656163004 Cr-Commit-Position: refs/heads/master@{#446557} Committed: https://chromium.googlesource.com/chromium/src/+/45fe549bd741139e0b64d4a90130642ed5407c77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/browser/service_worker/service_worker_client_utils.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
3 years, 11 months ago (2017-01-26 23:40:49 UTC) #5
Marijn Kruisselbrink
lgtm
3 years, 11 months ago (2017-01-26 23:56:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656163004/1
3 years, 11 months ago (2017-01-27 00:51:19 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 03:04:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45fe549bd741139e0b64d4a90130...

Powered by Google App Engine
This is Rietveld 408576698