Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2656103003: [wasm] flag for asm-wasm investigations (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] flag for asm-wasm investigations This is a flag useful for testing/perf investigations for asm-wasm. We can dump the internal representation of a asm.js module (when asm-wasm is enabled with --validate-asm) using --dump-wasm-module. We can't pick that module afterwards because it contains non-compliant opcodes - used as implementation detail of our asm-wasm pipeline. This flag forces asm.js origin on the decoder. BUG= Review-Url: https://codereview.chromium.org/2656103003 Cr-Commit-Position: refs/heads/master@{#42716} Committed: https://chromium.googlesource.com/v8/v8/+/373320aef92177fd1870825b47e8896df00efc52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Mircea Trofin
3 years, 11 months ago (2017-01-26 20:43:08 UTC) #5
bradnelson
lgtm
3 years, 11 months ago (2017-01-26 21:57:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656103003/1
3 years, 11 months ago (2017-01-26 21:57:37 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:59:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/373320aef92177fd1870825b47e8896df00...

Powered by Google App Engine
This is Rietveld 408576698