media/gpu: restore VPP scaling to default

media/gpu: restore VPP scaling to default
    
AVS (Advanced Video Scalar) support in the Intel vaapi driver is
not really as well optimized for AVS 8x8 coefficients.
    
It needs to sample the neighboring 8x8 pixels to get the result.
When the default flag is passed, the AVS only samples the neighboring
2x2 pixel to get the result. When the HQ flag is passed, it needs to
use 8x8 pixels.  Separately, I've taken a look at video output by
setting the scalar back to default and it should be sufficient for now.
    
Changing scaling property to VA_FILTER_SCALING_DEFAULT in
media/gpu/vaapi_wrapper.c requires an update to checksums
due to the differing filter properties in AVS Scaling options.
    
BUG=685432
TEST=video_decode_accelerator_unittest, visual decode of samples; see crbug.com/685432#c2 for samples; Thumbnail.* test
R=posciak@chromium.org,jrummell
    
Signed-off-by: Sean V Kelley <seanvk@posteo.de>;

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2656073003
Cr-Commit-Position: refs/heads/master@{#451601}
Committed: https://chromium.googlesource.com/chromium/src/+/4fc5997a7496bc2b803d049ab0218c385f6d6427

[seanvk, 2017-01-26 21:50:48]

Description was changed from

==========
media/gpu: restore VPP scaling to default

AVS (Advanced Video Scalar) support in the Intel vaapi driver is
not really as well optimized for AVS 8x8 coefficients.

It needs to sample the neighboring 8x8 pixels to get the result.
When the default flag is passed, the AVS only samples the neighboring
2x2 pixel to get the result. When the HQ flag is passed, it needs to
use 8x8 pixels.  Separately, I've taken a look at video output by
setting the scalar back to default and it should be sufficient for now.

BUG=685432
TEST=video_decode_accelerator_unittest, visual decode of samples; see
crbug.com/685432#c2 for samples
R=posciak@chromium.org

Signed-off-by: Sean V Kelley <seanvk@posteo.de>
==========

to

==========
media/gpu: restore VPP scaling to default

AVS (Advanced Video Scalar) support in the Intel vaapi driver is
not really as well optimized for AVS 8x8 coefficients.

It needs to sample the neighboring 8x8 pixels to get the result.
When the default flag is passed, the AVS only samples the neighboring
2x2 pixel to get the result. When the HQ flag is passed, it needs to
use 8x8 pixels.  Separately, I've taken a look at video output by
setting the scalar back to default and it should be sufficient for now.

BUG=685432
TEST=video_decode_accelerator_unittest, visual decode of samples; see
crbug.com/685432#c2 for samples
R=posciak@chromium.org

Signed-off-by: Sean V Kelley <seanvk@posteo.de>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Pawel Osciak, 2017-01-27 06:09:33]

This changes MD5 sums for the Thumbnail test case in
video_decode_accelerator_unittest, so the test does not pass.

Could you update the values in the md5 file as well please? Thank you.

[seanvk, 2017-01-28 00:12:42]

Sure will do.

Thanks,

Sean


On Thu, Jan 26, 2017 at 10:09 PM, <posciak@chromium.org> wrote:

> This changes MD5 sums for the Thumbnail test case in
> video_decode_accelerator_unittest, so the test does not pass.
>
> Could you update the values in the md5 file as well please? Thank you.
>
> https://codereview.chromium.org/2656073003/
>



-- 
Sean V. Kelley <sean.v.kelley@intel.com>
Open Source Technology Center / SSG
Intel Corp.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[seanvk, 2017-02-02 19:38:14]

On 2017/01/28 00:12:42, seanvk wrote:
> Sure will do.
> 
> Thanks,
> 
> Sean
> 
> 
> On Thu, Jan 26, 2017 at 10:09 PM, <mailto:posciak@chromium.org> wrote:
> 
> > This changes MD5 sums for the Thumbnail test case in
> > video_decode_accelerator_unittest, so the test does not pass.
> >
> > Could you update the values in the md5 file as well please? Thank you.
> >
> > https://codereview.chromium.org/2656073003/
> >
> 

Hi,

Build 1: Base build, browser from Source.
video_VideoDecodeAccelerator - vp8/h264/vp9  : PASS

Build 2: Base + GPU patch build, browser from Source
video_VideoDecodeAccelerator - vp8/h264/vp9  : PASS

We can confirm that the patch is picked up as evident from the screen shot of
the clips. Screenshot 2017-02-02 at 9.51.16 AM.png is for build 1 and Screenshot
2017-02-02 at 10.18.53 AM.png  is for build 2.

I'll attach the screenshots to the bug.

But the thing is we are not getting an md5sum error and the autotest passes.


Thanks,

Sean

> 
> 
> -- 
> Sean V. Kelley <mailto:sean.v.kelley@intel.com>
> Open Source Technology Center / SSG
> Intel Corp.
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[seanvk, 2017-02-08 22:05:51]

On 2017/02/02 19:38:14, seanvk wrote:
> On 2017/01/28 00:12:42, seanvk wrote:
> > Sure will do.
> > 
> > Thanks,
> > 
> > Sean
> > 
> > 
> > On Thu, Jan 26, 2017 at 10:09 PM, <mailto:posciak@chromium.org> wrote:
> > 
> > > This changes MD5 sums for the Thumbnail test case in
> > > video_decode_accelerator_unittest, so the test does not pass.
> > >
> > > Could you update the values in the md5 file as well please? Thank you.
> > >
> > > https://codereview.chromium.org/2656073003/

Updated md5sums https://codereview.chromium.org/2685953003

[seanvk, 2017-02-08 22:18:15]

On 2017/02/08 22:05:51, seanvk wrote:
> On 2017/02/02 19:38:14, seanvk wrote:
> > On 2017/01/28 00:12:42, seanvk wrote:
> > > Sure will do.
> > > 
> > > Thanks,
> > > 
> > > Sean
> > > 
> > > 
> > > On Thu, Jan 26, 2017 at 10:09 PM, <mailto:posciak@chromium.org> wrote:
> > > 
> > > > This changes MD5 sums for the Thumbnail test case in
> > > > video_decode_accelerator_unittest, so the test does not pass.
> > > >
> > > > Could you update the values in the md5 file as well please? Thank you.
> > > >
> > > > https://codereview.chromium.org/2656073003/
> 
> Updated md5sums https://codereview.chromium.org/2685953003

Corrected link for updated md5sums  https://codereview.chromium.org/2683953003

[seanvk, 2017-02-13 21:25:49]

On 2017/02/08 22:18:15, seanvk wrote:
> On 2017/02/08 22:05:51, seanvk wrote:
> > On 2017/02/02 19:38:14, seanvk wrote:
> > > On 2017/01/28 00:12:42, seanvk wrote:
> > > > Sure will do.
> > > > 
> > > > Thanks,
> > > > 
> > > > Sean
> > > > 
> > > > 
> > > > On Thu, Jan 26, 2017 at 10:09 PM, <mailto:posciak@chromium.org> wrote:
> > > > 
> > > > > This changes MD5 sums for the Thumbnail test case in
> > > > > video_decode_accelerator_unittest, so the test does not pass.
> > > > >
> > > > > Could you update the values in the md5 file as well please? Thank you.
> > > > >
> > > > > https://codereview.chromium.org/2656073003/
> > 
> > Updated md5sums https://codereview.chromium.org/2685953003
> 
> Corrected link for updated md5sums  https://codereview.chromium.org/2683953003

@pawel,

Just checking back with you on this patch.  Note i've also submitted a patch to
update the checksums.

Thanks,

Sean

[Pawel Osciak, 2017-02-17 02:03:02]

lgtm, but could you combine the md5 CL and this one into one please? That would
make reverts/tracking dependencies easier. Thank you.

[seanvk, 2017-02-17 17:48:13]

On 2017/02/17 02:03:02, Pawel Osciak wrote:
> lgtm, but could you combine the md5 CL and this one into one please? That
would
> make reverts/tracking dependencies easier. Thank you.

Sure, done.

[seanvk, 2017-02-17 17:51:06]

Description was changed from

==========
media/gpu: restore VPP scaling to default

AVS (Advanced Video Scalar) support in the Intel vaapi driver is
not really as well optimized for AVS 8x8 coefficients.

It needs to sample the neighboring 8x8 pixels to get the result.
When the default flag is passed, the AVS only samples the neighboring
2x2 pixel to get the result. When the HQ flag is passed, it needs to
use 8x8 pixels.  Separately, I've taken a look at video output by
setting the scalar back to default and it should be sufficient for now.

BUG=685432
TEST=video_decode_accelerator_unittest, visual decode of samples; see
crbug.com/685432#c2 for samples
R=posciak@chromium.org

Signed-off-by: Sean V Kelley <seanvk@posteo.de>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
media/gpu: restore VPP scaling to default
    
AVS (Advanced Video Scalar) support in the Intel vaapi driver is
not really as well optimized for AVS 8x8 coefficients.
    
It needs to sample the neighboring 8x8 pixels to get the result.
When the default flag is passed, the AVS only samples the neighboring
2x2 pixel to get the result. When the HQ flag is passed, it needs to
use 8x8 pixels.  Separately, I've taken a look at video output by
setting the scalar back to default and it should be sufficient for now.
    
Changing scaling property to VA_FILTER_SCALING_DEFAULT in
media/gpu/vaapi_wrapper.c requires an update to checksums
due to the differing filter properties in AVS Scaling options.
    
BUG=685432
TEST=video_decode_accelerator_unittest, visual decode of samples; see
crbug.com/685432#c2 for samples; Thumbnail.* test
R=posciak@chromium.org,jrummell
    
Signed-off-by: Sean V Kelley <seanvk@posteo.de>

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jrummell, 2017-02-17 18:52:35]

jrummell@chromium.org changed reviewers:
+ jrummell@chromium.org

[jrummell, 2017-02-17 18:52:36]

rs lgtm

[Pawel Osciak, 2017-02-17 22:04:13]

lgtm

[Pawel Osciak, 2017-02-17 22:04:22]

The CQ bit was checked by posciak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 22:05:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 00:09:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:09:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Pawel Osciak, 2017-02-20 07:42:27]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2017-02-20 07:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 08:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 08:53:09]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Pawel Osciak, 2017-02-20 08:54:38]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2017-02-20 08:54:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 09:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 09:47:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Pawel Osciak, 2017-02-20 11:24:54]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2017-02-20 11:25:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 12:03:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487589894318210,
"parent_rev": "f5b2e3e0903615be43cd1033a8399f8b4c98bd98", "commit_rev":
"4fc5997a7496bc2b803d049ab0218c385f6d6427"}

[commit-bot: I haz the power, 2017-02-20 12:03:50]

Description was changed from

==========
media/gpu: restore VPP scaling to default
    
AVS (Advanced Video Scalar) support in the Intel vaapi driver is
not really as well optimized for AVS 8x8 coefficients.
    
It needs to sample the neighboring 8x8 pixels to get the result.
When the default flag is passed, the AVS only samples the neighboring
2x2 pixel to get the result. When the HQ flag is passed, it needs to
use 8x8 pixels.  Separately, I've taken a look at video output by
setting the scalar back to default and it should be sufficient for now.
    
Changing scaling property to VA_FILTER_SCALING_DEFAULT in
media/gpu/vaapi_wrapper.c requires an update to checksums
due to the differing filter properties in AVS Scaling options.
    
BUG=685432
TEST=video_decode_accelerator_unittest, visual decode of samples; see
crbug.com/685432#c2 for samples; Thumbnail.* test
R=posciak@chromium.org,jrummell
    
Signed-off-by: Sean V Kelley <seanvk@posteo.de>

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
media/gpu: restore VPP scaling to default
    
AVS (Advanced Video Scalar) support in the Intel vaapi driver is
not really as well optimized for AVS 8x8 coefficients.
    
It needs to sample the neighboring 8x8 pixels to get the result.
When the default flag is passed, the AVS only samples the neighboring
2x2 pixel to get the result. When the HQ flag is passed, it needs to
use 8x8 pixels.  Separately, I've taken a look at video output by
setting the scalar back to default and it should be sufficient for now.
    
Changing scaling property to VA_FILTER_SCALING_DEFAULT in
media/gpu/vaapi_wrapper.c requires an update to checksums
due to the differing filter properties in AVS Scaling options.
    
BUG=685432
TEST=video_decode_accelerator_unittest, visual decode of samples; see
crbug.com/685432#c2 for samples; Thumbnail.* test
R=posciak@chromium.org,jrummell
    
Signed-off-by: Sean V Kelley <seanvk@posteo.de>

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2656073003
Cr-Commit-Position: refs/heads/master@{#451601}
Committed:
https://chromium.googlesource.com/chromium/src/+/4fc5997a7496bc2b803d049ab021...
==========

[commit-bot: I haz the power, 2017-02-20 12:03:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4fc5997a7496bc2b803d049ab021...