Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2655993002: cc: Fix animation bounds computation for multiple players (Closed)

Created:
3 years, 11 months ago by ajuma
Modified:
3 years, 10 months ago
Reviewers:
loyso (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix animation bounds computation for multiple players When one ElementAnimations has multiple AnimationPlayers, the ElementAnimations can have an animation that inflates bounds without every player having such an animation. This CL makes ElementAnimations correctly handle this case, fixing a DCHECK that was previously being hit in AnimationPlayer::TransformAnimationBoundsForBox. BUG=675545 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2655993002 Cr-Commit-Position: refs/heads/master@{#447812} Committed: https://chromium.googlesource.com/chromium/src/+/bd39ee6aee08c93647e9174347d7926e58b11012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M cc/animation/element_animations.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
ajuma
3 years, 11 months ago (2017-01-25 22:35:19 UTC) #6
loyso (OOO)
LGTM
3 years, 10 months ago (2017-02-01 00:25:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655993002/1
3 years, 10 months ago (2017-02-02 18:16:32 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 19:15:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd39ee6aee08c93647e9174347d7...

Powered by Google App Engine
This is Rietveld 408576698