[profiler] Fix a memory leak of CodeEvent objects

[profiler] Fix a memory leak of CodeEvent objects

BUG=v8:5753
Review-Url: https://codereview.chromium.org/2655963003
Cr-Commit-Position: refs/heads/master@{#42720}
Committed: https://chromium.googlesource.com/v8/v8/+/c99c25a988faa171a3c115e096b90b0e2df4232f

[alph, 2017-01-25 21:44:36]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 21:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-01-25 22:12:03]

alph@chromium.org changed reviewers:
+ cbruni@chromium.org, yangguo@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:18:40]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-01-26 08:36:36]

On 2017/01/25 22:12:03, alph wrote:

lgtm

[fmeawad, 2017-01-26 15:37:58]

fmeawad@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2017-01-26 15:37:58]

lgtm

https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.cc
File src/profiler/cpu-profiler.cc (right):

https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.c...
src/profiler/cpu-profiler.cc:289: CodeEntry::kEmptyNamePrefix, "native
V8Runtime"));
Another option is to generate them from the counter macros.

[alph, 2017-01-26 18:05:56]

https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.cc
File src/profiler/cpu-profiler.cc (right):

https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.c...
src/profiler/cpu-profiler.cc:289: CodeEntry::kEmptyNamePrefix, "native
V8Runtime"));
On 2017/01/26 15:37:58, fmeawad wrote:
> Another option is to generate them from the counter macros.

Sorry, I didn't get it. What do you mean?

[Camillo Bruni, 2017-01-26 18:17:31]

LGTM

https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.cc
File src/profiler/cpu-profiler.cc (right):

https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.c...
src/profiler/cpu-profiler.cc:286: DCHECK(counter->name());
nit: DCHECK_NOT_NULL

[fmeawad, 2017-01-26 18:54:42]

On 2017/01/26 18:05:56, alph wrote:
> https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.cc
> File src/profiler/cpu-profiler.cc (right):
> 
>
https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.c...
> src/profiler/cpu-profiler.cc:289: CodeEntry::kEmptyNamePrefix, "native
> V8Runtime"));
> On 2017/01/26 15:37:58, fmeawad wrote:
> > Another option is to generate them from the counter macros.
> 
> Sorry, I didn't get it. What do you mean?
I mean, you can use the COUNTER macros, similar to here:
https://cs.chromium.org/chromium/src/v8/src/counters.cc?rcl=0&l=307

[Camillo Bruni, 2017-01-26 19:17:57]

On 2017/01/26 at 18:54:42, fmeawad wrote:
> On 2017/01/26 18:05:56, alph wrote:
> >
https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.cc
> > File src/profiler/cpu-profiler.cc (right):
> > 
> >
https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.c...
> > src/profiler/cpu-profiler.cc:289: CodeEntry::kEmptyNamePrefix, "native
> > V8Runtime"));
> > On 2017/01/26 15:37:58, fmeawad wrote:
> > > Another option is to generate them from the counter macros.
> > 
> > Sorry, I didn't get it. What do you mean?
> I mean, you can use the COUNTER macros, similar to here:
https://cs.chromium.org/chromium/src/v8/src/counters.cc?rcl=0&l=307

I prefer not using them, binary size suffers quite a bit if you're unlucky and
stuff gets inlined :)

[alph, 2017-01-26 21:44:52]

On 2017/01/26 18:54:42, fmeawad wrote:
> On 2017/01/26 18:05:56, alph wrote:
> >
https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.cc
> > File src/profiler/cpu-profiler.cc (right):
> > 
> >
>
https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.c...
> > src/profiler/cpu-profiler.cc:289: CodeEntry::kEmptyNamePrefix, "native
> > V8Runtime"));
> > On 2017/01/26 15:37:58, fmeawad wrote:
> > > Another option is to generate them from the counter macros.
> > 
> > Sorry, I didn't get it. What do you mean?
> I mean, you can use the COUNTER macros, similar to here:
> https://cs.chromium.org/chromium/src/v8/src/counters.cc?rcl=0&l=307

What's the point of using it here? There are hundreds of them and having them in
an unrolled loop will increase the binary size a lot. Am I missing something?

[fmeawad, 2017-01-26 23:08:09]

On 2017/01/26 21:44:52, alph wrote:
> On 2017/01/26 18:54:42, fmeawad wrote:
> > On 2017/01/26 18:05:56, alph wrote:
> > >
> https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.cc
> > > File src/profiler/cpu-profiler.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2655963003/diff/1/src/profiler/cpu-profiler.c...
> > > src/profiler/cpu-profiler.cc:289: CodeEntry::kEmptyNamePrefix, "native
> > > V8Runtime"));
> > > On 2017/01/26 15:37:58, fmeawad wrote:
> > > > Another option is to generate them from the counter macros.
> > > 
> > > Sorry, I didn't get it. What do you mean?
> > I mean, you can use the COUNTER macros, similar to here:
> > https://cs.chromium.org/chromium/src/v8/src/counters.cc?rcl=0&l=307
> 
> What's the point of using it here? There are hundreds of them and having them
in
> an unrolled loop will increase the binary size a lot. Am I missing something?
I always forget about the binary size.
LGTM

[alph, 2017-01-27 00:20:14]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:20:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 01:12:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485476414712160, "parent_rev":
"2a78f2980b3dc56cde5a10b1b554b38d2cc9f4c0", "commit_rev":
"c99c25a988faa171a3c115e096b90b0e2df4232f"}

[commit-bot: I haz the power, 2017-01-27 01:12:59]

Description was changed from

==========
[profiler] Fix a memory leak of CodeEvent objects

BUG=v8:5753
==========

to

==========
[profiler] Fix a memory leak of CodeEvent objects

BUG=v8:5753

Review-Url: https://codereview.chromium.org/2655963003
Cr-Commit-Position: refs/heads/master@{#42720}
Committed:
https://chromium.googlesource.com/v8/v8/+/c99c25a988faa171a3c115e096b90b0e2df...
==========

[commit-bot: I haz the power, 2017-01-27 01:13:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c99c25a988faa171a3c115e096b90b0e2df...