|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by Ken Rockot(use gerrit already) Modified:
3 years, 11 months ago CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBake chrome mash catalog into MashRunner
This bakes the catalog manifest for the Chrome Mash environment
into the binary rather than having it load from disk at runtime.
BUG=685194
Review-Url: https://codereview.chromium.org/2655943002
Cr-Commit-Position: refs/heads/master@{#446248}
Committed: https://chromium.googlesource.com/chromium/src/+/fa896eed346c508afe00d01cf562fe18e0436600
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
kylechar@chromium.org changed reviewers: + kylechar@chromium.org
Tested this running a Chromebook Pixel. Everything works fine again. lgtm.
rockot@chromium.org changed reviewers: + sky@chromium.org - kylechar@chromium.org
Scott PTAL!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
LGTM
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485407299015530, "parent_rev":
"b7149331e2de8627de71071528d906e11c274e3b", "commit_rev":
"fa896eed346c508afe00d01cf562fe18e0436600"}
Message was sent while issue was closed.
Description was changed from ========== Bake chrome mash catalog into MashRunner This bakes the catalog manifest for the Chrome Mash environment into the binary rather than having it load from disk at runtime. BUG=685194 ========== to ========== Bake chrome mash catalog into MashRunner This bakes the catalog manifest for the Chrome Mash environment into the binary rather than having it load from disk at runtime. BUG=685194 Review-Url: https://codereview.chromium.org/2655943002 Cr-Commit-Position: refs/heads/master@{#446248} Committed: https://chromium.googlesource.com/chromium/src/+/fa896eed346c508afe00d01cf562... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fa896eed346c508afe00d01cf562... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
