Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2655943002: Bake chrome mash catalog into MashRunner (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
Reviewers:
kylechar, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bake chrome mash catalog into MashRunner This bakes the catalog manifest for the Chrome Mash environment into the binary rather than having it load from disk at runtime. BUG=685194 Review-Url: https://codereview.chromium.org/2655943002 Cr-Commit-Position: refs/heads/master@{#446248} Committed: https://chromium.googlesource.com/chromium/src/+/fa896eed346c508afe00d01cf562fe18e0436600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M chrome/app/mash/BUILD.gn View 3 chunks +4 lines, -12 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
kylechar
Tested this running a Chromebook Pixel. Everything works fine again. lgtm.
3 years, 11 months ago (2017-01-25 19:21:39 UTC) #4
Ken Rockot(use gerrit already)
Scott PTAL!
3 years, 11 months ago (2017-01-25 19:22:27 UTC) #6
sky
LGTM
3 years, 11 months ago (2017-01-25 22:05:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655943002/1
3 years, 11 months ago (2017-01-25 22:07:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220227)
3 years, 11 months ago (2017-01-26 01:19:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655943002/1
3 years, 11 months ago (2017-01-26 01:22:24 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220643)
3 years, 11 months ago (2017-01-26 05:04:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655943002/1
3 years, 11 months ago (2017-01-26 05:08:34 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 06:14:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa896eed346c508afe00d01cf562...

Powered by Google App Engine
This is Rietveld 408576698