Issue 265593004: Always initialize the debugger eagerly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265593004: Always initialize the debugger eagerly. (Closed)

Created:
6 years, 7 months ago by Yang

Modified:
6 years, 7 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Always initialize the debugger eagerly. There is no point doing it lazily, since compiling and executing the tiniest piece of code triggers lazy init. Also removed some dead code. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21135

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -106 lines)			Patch
M	src/arm/debug-arm.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm64/debug-arm64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/debug.h	View	6 chunks	+0 lines, -30 lines	0 comments	Download
M	src/debug.cc	View	3 chunks	+1 line, -23 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/debug-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/isolate.h	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	src/isolate.cc	View	6 chunks	+4 lines, -20 lines	0 comments	Download
M	src/isolate-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/liveedit.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/debug-mips.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/serialize.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/x64/debug-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

6 years, 7 months ago (2014-05-05 07:10:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21135 (presubmit successful).