Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: src/liveedit.cc

Issue 265593004: Always initialize the debugger eagerly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate-inl.h ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 #include "v8.h" 6 #include "v8.h"
7 7
8 #include "liveedit.h" 8 #include "liveedit.h"
9 9
10 #include "code-stubs.h" 10 #include "code-stubs.h"
(...skipping 1551 matching lines...) Expand 10 before | Expand all | Expand 10 after
1562 // Check the nature of the top frame. 1562 // Check the nature of the top frame.
1563 Isolate* isolate = bottom_js_frame->isolate(); 1563 Isolate* isolate = bottom_js_frame->isolate();
1564 Code* pre_top_frame_code = pre_top_frame->LookupCode(); 1564 Code* pre_top_frame_code = pre_top_frame->LookupCode();
1565 bool frame_has_padding; 1565 bool frame_has_padding;
1566 if (pre_top_frame_code->is_inline_cache_stub() && 1566 if (pre_top_frame_code->is_inline_cache_stub() &&
1567 pre_top_frame_code->is_debug_stub()) { 1567 pre_top_frame_code->is_debug_stub()) {
1568 // OK, we can drop inline cache calls. 1568 // OK, we can drop inline cache calls.
1569 *mode = Debug::FRAME_DROPPED_IN_IC_CALL; 1569 *mode = Debug::FRAME_DROPPED_IN_IC_CALL;
1570 frame_has_padding = Debug::FramePaddingLayout::kIsSupported; 1570 frame_has_padding = Debug::FramePaddingLayout::kIsSupported;
1571 } else if (pre_top_frame_code == 1571 } else if (pre_top_frame_code ==
1572 isolate->debug()->debug_break_slot()) { 1572 isolate->builtins()->builtin(Builtins::kSlot_DebugBreak)) {
1573 // OK, we can drop debug break slot. 1573 // OK, we can drop debug break slot.
1574 *mode = Debug::FRAME_DROPPED_IN_DEBUG_SLOT_CALL; 1574 *mode = Debug::FRAME_DROPPED_IN_DEBUG_SLOT_CALL;
1575 frame_has_padding = Debug::FramePaddingLayout::kIsSupported; 1575 frame_has_padding = Debug::FramePaddingLayout::kIsSupported;
1576 } else if (pre_top_frame_code == 1576 } else if (pre_top_frame_code ==
1577 isolate->builtins()->builtin( 1577 isolate->builtins()->builtin(
1578 Builtins::kFrameDropper_LiveEdit)) { 1578 Builtins::kFrameDropper_LiveEdit)) {
1579 // OK, we can drop our own code. 1579 // OK, we can drop our own code.
1580 pre_top_frame = frames[top_frame_index - 2]; 1580 pre_top_frame = frames[top_frame_index - 2];
1581 top_frame = frames[top_frame_index - 1]; 1581 top_frame = frames[top_frame_index - 1];
1582 *mode = Debug::CURRENTLY_SET_MODE; 1582 *mode = Debug::CURRENTLY_SET_MODE;
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
1970 void LiveEditFunctionTracker::RecordRootFunctionInfo(Handle<Code> code) { 1970 void LiveEditFunctionTracker::RecordRootFunctionInfo(Handle<Code> code) {
1971 isolate_->active_function_info_listener()->FunctionCode(code); 1971 isolate_->active_function_info_listener()->FunctionCode(code);
1972 } 1972 }
1973 1973
1974 1974
1975 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 1975 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
1976 return isolate->active_function_info_listener() != NULL; 1976 return isolate->active_function_info_listener() != NULL;
1977 } 1977 }
1978 1978
1979 } } // namespace v8::internal 1979 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate-inl.h ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698