Issue 265593003: DM: when 32-bit, disable pathops internal threading by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265593003: DM: when 32-bit, disable pathops internal threading by default (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
borenet, mtklein

CC:
skia-review_googlegroups.com, caryclark

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

DM: when 32-bit, disable pathops internal threading by default Before this change, when limited to 4G, pathops threaded tests were the weak link RAM-consumption-wise (in thread-local font caches) up until about 12 cores, where other problems begin to pile up too. Tested by running: ulimit -Sv 4194304 out/Debug/dm --threads N [--pathOpsSingleThread] After this, we're _probably_ good to go on 32-bit machines with 8 cores. BUG=skia:2478 Committed: http://code.google.com/p/skia/source/detail?r=14463

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	dm/DMTestTask.cpp	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/265593003/1

6 years, 7 months ago (2014-04-30 14:49:50 UTC) #4

Message was sent while issue was closed.

Change committed as 14463

Expand Messages | Collapse Messages