Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: dm/DMTestTask.cpp

Issue 265593003: DM: when 32-bit, disable pathops internal threading by default (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #include "DMTestTask.h" 1 #include "DMTestTask.h"
2 #include "DMUtil.h" 2 #include "DMUtil.h"
3 #include "SkCommandLineFlags.h" 3 #include "SkCommandLineFlags.h"
4 4
5 // When PathOps threaded tests get going, they're briefly a big consumer of lots of RAM.
6 // We disable the internal threading there by default on 32-bit builds.
7 static const bool is32Bit = sizeof(void*) == 4;
8
5 DEFINE_bool2(pathOpsExtended, x, false, "Run extended pathOps tests."); 9 DEFINE_bool2(pathOpsExtended, x, false, "Run extended pathOps tests.");
6 DEFINE_bool2(pathOpsSingleThread, z, false, "Disallow pathOps tests from using t hreads."); 10 DEFINE_bool2(pathOpsSingleThread, z, is32Bit, "Disallow pathOps tests from using threads.");
7 DEFINE_bool2(pathOpsVerbose, V, false, "Tell pathOps tests to be verbose.") ; 11 DEFINE_bool2(pathOpsVerbose, V, false, "Tell pathOps tests to be verbose.") ;
8 12
9 namespace DM { 13 namespace DM {
10 14
11 bool TestReporter::allowExtendedTest() const { return FLAGS_pathOpsExtended; } 15 bool TestReporter::allowExtendedTest() const { return FLAGS_pathOpsExtended; }
12 bool TestReporter::allowThreaded() const { return !FLAGS_pathOpsSingleThread ; } 16 bool TestReporter::allowThreaded() const { return !FLAGS_pathOpsSingleThread ; }
13 bool TestReporter::verbose() const { return FLAGS_pathOpsVerbose; } 17 bool TestReporter::verbose() const { return FLAGS_pathOpsVerbose; }
14 18
15 static SkString test_name(const char* name) { 19 static SkString test_name(const char* name) {
16 SkString result("test "); 20 SkString result("test ");
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 if (!fTest->passed()) { 52 if (!fTest->passed()) {
49 this->fail(fTestReporter.failure()); 53 this->fail(fTestReporter.failure());
50 } 54 }
51 } 55 }
52 56
53 bool GpuTestTask::shouldSkip() const { 57 bool GpuTestTask::shouldSkip() const {
54 return kGPUDisabled; 58 return kGPUDisabled;
55 } 59 }
56 60
57 } // namespace DM 61 } // namespace DM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698