Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2655923003: [expect_tests] Add show_missing flag to coverage.report. (Closed)

Created:
3 years, 11 months ago by iannucci
Modified:
3 years, 11 months ago
Reviewers:
bpastene, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[expect_tests] Add show_missing flag to coverage.report. Apparently in coverage 4.0 this function grew a new parameter and the default was set to False. R=bpastene@chromium.org, martiniss@chromium.org BUG=685266 Review-Url: https://codereview.chromium.org/2655923003 Committed: https://github.com/luci/recipes-py/commit/401a93b1055698158b3fb50a98aebb51e830ac44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M recipe_engine/third_party/expect_tests/cover.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
iannucci
3 years, 11 months ago (2017-01-25 18:58:09 UTC) #1
martiniss
lgtm The new parameter isn't even documented :( http://coverage.readthedocs.io/en/coverage-4.3.4/api_coverage.html?highlight=show_missing#coverage.Coverage.report
3 years, 11 months ago (2017-01-25 19:00:02 UTC) #2
bpastene
lgtm, thanks!
3 years, 11 months ago (2017-01-25 19:02:11 UTC) #3
iannucci
Yeah, I had to poke at the coverage code to figure it out. I tried ...
3 years, 11 months ago (2017-01-25 19:06:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655923003/1
3 years, 11 months ago (2017-01-25 19:06:34 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 19:09:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/401a93b1055698158b3fb50a98aebb51e83...

Powered by Google App Engine
This is Rietveld 408576698