Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2655903002: [cipd/common] Add various pinslice types. (Closed)

Created:
3 years, 11 months ago by iannucci
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -1 line) Patch
M cipd/client/cipd/common/common.go View 3 chunks +86 lines, -1 line 0 comments Download
M cipd/client/cipd/common/common_test.go View 1 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
iannucci
3 years, 11 months ago (2017-01-25 18:13:33 UTC) #1
Vadim Sh.
lgtm
3 years, 11 months ago (2017-01-25 18:28:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655903002/1
3 years, 11 months ago (2017-01-25 20:13:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/33f014748e905110) ...
3 years, 11 months ago (2017-01-25 20:14:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655903002/20001
3 years, 11 months ago (2017-01-25 20:27:03 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 20:34:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/611755866fc803e2c1ce9cf1e5374cbf3456ecd2

Powered by Google App Engine
This is Rietveld 408576698