Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2655873003: Remove PlatformEvent it is no longer used. (Closed)

Created:
3 years, 10 months ago by dtapuska
Modified:
3 years, 10 months ago
Reviewers:
bokan, jbroman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, Navid Zolghadr, pfeldman+blink_chromium.org, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PlatformEvent it is no longer used. All events have been converted to use WebInputEvent directly. Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit BUG=625684 Review-Url: https://codereview.chromium.org/2655873003 Cr-Commit-Position: refs/heads/master@{#450433} Committed: https://chromium.googlesource.com/chromium/src/+/4e19843aade96a4a3b2254ba00896ddd15e5a153

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Remove PlatformEvent it is no longer used. #

Total comments: 2

Patch Set 5 : Remove PlatformEvent it is no longer used. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -252 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/DragEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/DragEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/GestureEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.cpp View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/UIEventWithKeyState.h View 3 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp View 5 chunks +28 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventWithHitTestResults.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/PlatformEvent.h View 1 chunk +0 lines, -112 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 2 3 4 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (21 generated)
dtapuska
3 years, 10 months ago (2017-01-30 19:54:39 UTC) #12
dtapuska
jbroman@chromium.org; seems I need a platform OWNER as well.
3 years, 10 months ago (2017-01-30 21:24:29 UTC) #16
jbroman
platform lgtm
3 years, 10 months ago (2017-01-30 22:04:07 UTC) #17
bokan
Sorry for the delay. lgtm % nit https://codereview.chromium.org/2655873003/diff/60001/third_party/WebKit/Source/core/input/GestureManager.h File third_party/WebKit/Source/core/input/GestureManager.h (right): https://codereview.chromium.org/2655873003/diff/60001/third_party/WebKit/Source/core/input/GestureManager.h#newcode13 third_party/WebKit/Source/core/input/GestureManager.h:13: #include "wtf/Time.h" ...
3 years, 10 months ago (2017-02-02 20:33:18 UTC) #18
dtapuska
https://codereview.chromium.org/2655873003/diff/60001/third_party/WebKit/Source/core/input/GestureManager.h File third_party/WebKit/Source/core/input/GestureManager.h (right): https://codereview.chromium.org/2655873003/diff/60001/third_party/WebKit/Source/core/input/GestureManager.h#newcode13 third_party/WebKit/Source/core/input/GestureManager.h:13: #include "wtf/Time.h" On 2017/02/02 20:33:18, bokan (OOO until Feb ...
3 years, 10 months ago (2017-02-14 15:53:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655873003/80001
3 years, 10 months ago (2017-02-14 16:06:54 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 19:28:29 UTC) #28
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4e19843aade96a4a3b2254ba0089...

Powered by Google App Engine
This is Rietveld 408576698