Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2655853002: Use explicit WebString conversions in plugins code (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in plugins code As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 R=tommycli@chromium.org Review-Url: https://codereview.chromium.org/2655853002 Cr-Commit-Position: refs/heads/master@{#446181} Committed: https://chromium.googlesource.com/chromium/src/+/2ae40e827e9a0164e0cf399f5ad4112891de773e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
kinuko
Mechanical changes only. Can you review?
3 years, 11 months ago (2017-01-25 12:43:00 UTC) #3
tommycli
On 2017/01/25 12:43:00, kinuko wrote: > Mechanical changes only. Can you review? lgtm thanks!
3 years, 11 months ago (2017-01-25 22:32:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655853002/1
3 years, 11 months ago (2017-01-26 00:25:21 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 00:57:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ae40e827e9a0164e0cf399f5ad4...

Powered by Google App Engine
This is Rietveld 408576698