[memory-infra] Whitelist sync model type counters.

[tracing] Whitelist sync model type counters.

This CL whitelists model type counters that were added to the
sync MDP in crrev.com/2651563004.

BUG=675683
Review-Url: https://codereview.chromium.org/2655833003
Cr-Commit-Position: refs/heads/master@{#446373}
Committed: https://chromium.googlesource.com/chromium/src/+/7ecd005e3a871cc9a4979c0a3ef822d9e7c0a787

[DmitrySkiba, 2017-01-25 18:42:52]

dskiba@chromium.org changed reviewers:
+ primiano@chromium.org, ssid@chromium.org

[DmitrySkiba, 2017-01-25 18:42:53]

PTAL

[Primiano Tucci (use gerrit), 2017-01-25 22:00:42]

LGTM
although in the cl title I'd put [memory-infra] not [tracing].
it makes it clearer that this CL affects memory instrumentation

[ssid, 2017-01-25 22:24:09]

https://codereview.chromium.org/2655833003/diff/1/base/trace_event/memory_inf...
File base/trace_event/memory_infra_background_whitelist.cc (right):

https://codereview.chromium.org/2655833003/diff/1/base/trace_event/memory_inf...
base/trace_event/memory_infra_background_whitelist.cc:126:
"sync/0x?/model_type/WIFI_CREDENTIAL",
Do we have a comment in Sync ModelType definitions to update this file if that
is updated?

If not let's remove these from whitelist after our issue is fixed, ie lets see
what model is causing the issue and once fixed, let's not add the model type to
slow reports anymore. Also this would cause lot of extra string comparisons at
each CreateAllocatorDump(). wdyt?

[DmitrySkiba, 2017-01-25 23:45:40]

Description was changed from

==========
[tracing] Whitelist sync model type counters.

This CL whitelists model type counters that were added to the
sync MDP in crrev.com/2651563004.

BUG=675683
==========

to

==========
[tracing] Whitelist sync model type counters.

This CL whitelists model type counters that were added to the
sync MDP in crrev.com/2651563004.

BUG=675683
==========

[DmitrySkiba, 2017-01-25 23:47:16]

On 2017/01/25 22:24:09, ssid wrote:
>
https://codereview.chromium.org/2655833003/diff/1/base/trace_event/memory_inf...
> File base/trace_event/memory_infra_background_whitelist.cc (right):
> 
>
https://codereview.chromium.org/2655833003/diff/1/base/trace_event/memory_inf...
> base/trace_event/memory_infra_background_whitelist.cc:126:
> "sync/0x?/model_type/WIFI_CREDENTIAL",
> Do we have a comment in Sync ModelType definitions to update this file if that
> is updated?

No, I don't think so.

> 
> If not let's remove these from whitelist after our issue is fixed, ie lets see
> what model is causing the issue and once fixed, let's not add the model type
to
> slow reports anymore. Also this would cause lot of extra string comparisons at
> each CreateAllocatorDump(). wdyt?

Sounds good.

[DmitrySkiba, 2017-01-25 23:47:19]

The CQ bit was checked by dskiba@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:48:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 23:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:53:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[DmitrySkiba, 2017-01-26 16:29:12]

The CQ bit was checked by dskiba@chromium.org

[commit-bot: I haz the power, 2017-01-26 16:29:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 17:51:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485448152136280, "parent_rev":
"9f1ddc6deb94f709ca8a8635d270749560295a72", "commit_rev":
"7ecd005e3a871cc9a4979c0a3ef822d9e7c0a787"}

[commit-bot: I haz the power, 2017-01-26 17:52:18]

Description was changed from

==========
[tracing] Whitelist sync model type counters.

This CL whitelists model type counters that were added to the
sync MDP in crrev.com/2651563004.

BUG=675683
==========

to

==========
[tracing] Whitelist sync model type counters.

This CL whitelists model type counters that were added to the
sync MDP in crrev.com/2651563004.

BUG=675683

Review-Url: https://codereview.chromium.org/2655833003
Cr-Commit-Position: refs/heads/master@{#446373}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ecd005e3a871cc9a4979c0a3ef8...
==========

[commit-bot: I haz the power, 2017-01-26 17:52:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7ecd005e3a871cc9a4979c0a3ef8...