Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2655803006: INPUT element: avoid crash in EventDispatcher::dispatchEventPostProcess(). (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: avoid crash in EventDispatcher::dispatchEventPostProcess(). This CL swaps AX-related code and postDispatchEventHandler() in dispatchEventPostProcess() postDispatchEventHandler() may dispatch a 'change' event, and an event handler might update m_event. accessing m_event->target() after postDispatchEventHandler() isn't safe. BUG=685450 Review-Url: https://codereview.chromium.org/2655803006 Cr-Commit-Position: refs/heads/master@{#446258} Committed: https://chromium.googlesource.com/chromium/src/+/69fa20d42cdab2a175275293d3953c7ca3ba19dc

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-dispatch-click-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
tkent
keishi@, would you review this please?
3 years, 11 months ago (2017-01-26 06:16:31 UTC) #12
keishi
LGTM
3 years, 11 months ago (2017-01-26 06:19:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655803006/20001
3 years, 11 months ago (2017-01-26 06:39:30 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 06:44:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/69fa20d42cdab2a175275293d395...

Powered by Google App Engine
This is Rietveld 408576698