Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2655793004: Also handle renaming method names inside ON_CALL macro calls. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
danakj, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename method names used inside GMock's ON_CALL macro calls. BUG=677544 Review-Url: https://codereview.chromium.org/2655793004 Cr-Commit-Position: refs/heads/master@{#446365} Committed: https://chromium.googlesource.com/chromium/src/+/a798de99a96ac2c9726b1ad4fe10630a34bb47c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 4 chunks +15 lines, -12 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/gmock-expected.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/gmock-original.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Łukasz Anforowicz
Daniel or Dana - could you PTAL?
3 years, 11 months ago (2017-01-25 23:45:07 UTC) #3
danakj
LGTM
3 years, 11 months ago (2017-01-26 16:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655793004/1
3 years, 11 months ago (2017-01-26 17:20:57 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 17:38:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a798de99a96ac2c9726b1ad4fe10...

Powered by Google App Engine
This is Rietveld 408576698