Issue 2655673003: Update tests for FF 51

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2655673003: Update tests for FF 51 (Closed)

Created:
3 years, 11 months ago by vsm

Modified:
3 years, 11 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update tests for FF 51 A handful of tests started working in FF 51. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/a27adee73677c67705069a747baeb3ce45bc5491

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	pkg/dev_compiler/test/browser/language_tests.js	View		5 chunks	+7 lines, -7 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

https://codereview.chromium.org/2655673003/diff/1/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2655673003/diff/1/pkg/dev_compiler/test/browser/language_tests.js#newcode138 pkg/dev_compiler/test/browser/language_tests.js:138: 'for_variable_capture_test': is.firefox('<=50') ? pass : fail, Note, this is ...

3 years, 11 months ago (2017-01-24 16:32:01 UTC) #1

vsm

Committed patchset #1 (id:1) manually as a27adee73677c67705069a747baeb3ce45bc5491 (presubmit successful).

3 years, 11 months ago (2017-01-24 16:32:26 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages