Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2655673003: Update tests for FF 51 (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/browser/language_tests.js
diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js
index d7222dc4d9b2db71f05107c622a36abc632607b3..f5128e8ba2495f675e0569589b05a86436555a6e 100644
--- a/pkg/dev_compiler/test/browser/language_tests.js
+++ b/pkg/dev_compiler/test/browser/language_tests.js
@@ -135,7 +135,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'field_optimization3_test': fail,
'final_syntax_test_08_multi': fail,
'first_class_types_test': fail,
- 'for_variable_capture_test': chrome_fail,
+ 'for_variable_capture_test': is.firefox('<=50') ? pass : fail,
vsm 2017/01/24 16:32:01 Note, this is the opposite of everything else - it
'function_subtype0_test': fail,
'function_subtype1_test': fail,
'function_subtype2_test': fail,
@@ -222,7 +222,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'mixin_regress_13688_test': fail,
'modulo_test': fail,
'named_parameter_clash_test': fail,
- 'named_parameters_passing_falsy_test': firefox_fail,
+ 'named_parameters_passing_falsy_test': is.firefox('<=50') ? fail : pass,
'nan_identical_test': fail,
'nested_switch_label_test': fail,
'number_identifier_test_05_multi': fail,
@@ -294,7 +294,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'double_parse_test_02_multi': firefox_fail,
'error_stack_trace1_test': fail,
'error_stack_trace2_test': fail,
- 'for_in_test': firefox_fail,
+ 'for_in_test': is.firefox('<=50') ? fail : pass,
'hash_map2_test': skip_timeout,
'hash_set_test_01_multi': fail,
'hidden_library2_test_01_multi': fail,
@@ -316,14 +316,14 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'main_test': fail,
'map_keys2_test': fail,
'map_to_string_test': fail,
- 'map_from_iterable_test': firefox_fail,
+ 'map_from_iterable_test': is.firefox('<=50') ? fail : pass,
'nan_infinity_test_01_multi': fail,
'null_nosuchmethod_test': fail,
'null_test': fail,
'num_sign_test': fail,
'regress_r21715_test': fail,
'throw_half_surrogate_pair_test_02_multi': fail,
- 'splay_tree_from_iterable_test': firefox_fail,
+ 'splay_tree_from_iterable_test': is.firefox('<=50') ? fail : pass,
'string_case_test_01_multi': firefox_fail,
'string_fromcharcodes_test': skip_timeout,
'string_operations_with_null_test': fail,
@@ -332,11 +332,11 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'symbol_reserved_word_test_12_multi': fail,
'throw_half_surrogate_pair_test_01_multi': fail,
'unicode_test': firefox_fail,
- 'uri_parameters_all_test': firefox_fail,
+ 'uri_parameters_all_test': is.firefox('<=50') ? fail : pass,
// TODO(rnystrom): Times out because it tests a huge number of
// combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200).
'uri_parse_test': skip_timeout,
- 'uri_test': firefox_fail,
+ 'uri_test': is.firefox('<=50') ? fail : pass,
'list_insert_test': fail,
'list_removeat_test': fail,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698