|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by bcwhite Modified:
3 years, 11 months ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse atomic ops for managing g_allocator.
BUG=684498
Review-Url: https://codereview.chromium.org/2655673002
Cr-Commit-Position: refs/heads/master@{#445805}
Committed: https://chromium.googlesource.com/chromium/src/+/a7d5177f1f8d47bcae75304d19b2728533e267f6
Patch Set 1 #Patch Set 2 : rebased #
Total comments: 2
Patch Set 3 : use Get() instead of g_allocator #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bcwhite@chromium.org changed reviewers: + asvitkine@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent... File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent... base/metrics/persistent_histogram_allocator.cc:508: if (subtle::NoBarrier_Load(&g_allocator)) { Nit: Just use Get() here.
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent... File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent... base/metrics/persistent_histogram_allocator.cc:508: if (subtle::NoBarrier_Load(&g_allocator)) { On 2017/01/24 17:45:19, Alexei Svitkine (slow) wrote: > Nit: Just use Get() here. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2655673002/#ps40001 (title: "use Get() instead of g_allocator")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485290779288600,
"parent_rev": "0a362f539460ef5cfd4ca3143fc790b683dbec15", "commit_rev":
"a7d5177f1f8d47bcae75304d19b2728533e267f6"}
Message was sent while issue was closed.
Description was changed from ========== Use atomic ops for managing g_allocator. BUG=684498 ========== to ========== Use atomic ops for managing g_allocator. BUG=684498 Review-Url: https://codereview.chromium.org/2655673002 Cr-Commit-Position: refs/heads/master@{#445805} Committed: https://chromium.googlesource.com/chromium/src/+/a7d5177f1f8d47bcae75304d19b2... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a7d5177f1f8d47bcae75304d19b2... |
