Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2655673002: Use atomic ops for managing g_allocator. (Closed)

Created:
3 years, 11 months ago by bcwhite
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use atomic ops for managing g_allocator. BUG=684498 Review-Url: https://codereview.chromium.org/2655673002 Cr-Commit-Position: refs/heads/master@{#445805} Committed: https://chromium.googlesource.com/chromium/src/+/a7d5177f1f8d47bcae75304d19b2728533e267f6

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : use Get() instead of g_allocator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M base/metrics/persistent_histogram_allocator.cc View 1 2 7 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
bcwhite
3 years, 11 months ago (2017-01-24 16:27:06 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent_histogram_allocator.cc#newcode508 base/metrics/persistent_histogram_allocator.cc:508: if (subtle::NoBarrier_Load(&g_allocator)) { Nit: Just use Get() here.
3 years, 11 months ago (2017-01-24 17:45:20 UTC) #9
bcwhite
https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent_histogram_allocator.cc File base/metrics/persistent_histogram_allocator.cc (right): https://codereview.chromium.org/2655673002/diff/20001/base/metrics/persistent_histogram_allocator.cc#newcode508 base/metrics/persistent_histogram_allocator.cc:508: if (subtle::NoBarrier_Load(&g_allocator)) { On 2017/01/24 17:45:19, Alexei Svitkine (slow) ...
3 years, 11 months ago (2017-01-24 18:53:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655673002/40001
3 years, 11 months ago (2017-01-24 20:47:02 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 21:00:04 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a7d5177f1f8d47bcae75304d19b2...

Powered by Google App Engine
This is Rietveld 408576698