Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2655653004: Fixes gn-check errors with enable_plugins=false. (Closed)

Created:
3 years, 11 months ago by alokp
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, brettw, xhwang
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes gn-check errors with enable_plugins=false. BUG=666790 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2655653004 Cr-Commit-Position: refs/heads/master@{#446170} Committed: https://chromium.googlesource.com/chromium/src/+/76ed9ed0d250af589239a52d427a1f72991dee71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/debug_urls.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/font_utils_linux.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/all_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
alokp
xhwang: widevine-related changes jam: everything else For context, please see: https://codereview.chromium.org/2649353007/ which disables plugins for ...
3 years, 11 months ago (2017-01-25 06:16:39 UTC) #5
jam
->Brett
3 years, 11 months ago (2017-01-25 18:37:08 UTC) #9
xhwang
media/cdm lgtm
3 years, 11 months ago (2017-01-25 18:42:39 UTC) #10
brettw
lgtm
3 years, 11 months ago (2017-01-25 22:56:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655653004/1
3 years, 11 months ago (2017-01-25 23:12:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350465)
3 years, 11 months ago (2017-01-25 23:22:08 UTC) #15
alokp
tsepez: content/common/all_messages.h
3 years, 11 months ago (2017-01-25 23:28:02 UTC) #17
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-25 23:31:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655653004/1
3 years, 11 months ago (2017-01-26 00:10:17 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 00:18:21 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76ed9ed0d250af589239a52d427a...

Powered by Google App Engine
This is Rietveld 408576698