[task_manager] Add ARC process whitelist.

[task_manager] Add ARC process whitelist.

Filter which Android processes we display in the task manager by an
explicit whitelist and based on ProcessState.

BUG=654564
Review-Url: https://codereview.chromium.org/2655633002
Cr-Commit-Position: refs/heads/master@{#448580}
Committed: https://chromium.googlesource.com/chromium/src/+/13452f1a1149352dc13b53027bbceac54ed217e6

[Eliot Courtney, 2017-01-24 07:11:32]

The CQ bit was checked by edcourtney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 07:12:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eliot Courtney, 2017-01-24 07:14:02]

edcourtney@chromium.org changed reviewers:
+ hctsai@chromium.org, hirono@chromium.org, nick@chromium.org

[Eliot Courtney, 2017-01-24 07:14:02]

As discussed in the bug, I had a go at implementing a whitelist for system apps.
I wasn't quite sure about what ProcessState's should be implicitly allowed. What
I have currently gets rid of of the majority of the Android processes.

[commit-bot: I haz the power, 2017-01-24 08:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 08:18:25]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2017-01-24 17:09:40]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2017-01-24 17:09:42]

drive-by

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
File chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc
(right):

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc:64: if
(!whitelist_.ShouldDisplayProcess(entry))
this does not look very whitelist-y to me :P (otherwise it would be something
along the lines of "if in whitelist, always add it").

how about calling it ArcProcessFilter instead?

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
File chrome/browser/task_manager/providers/arc/arc_process_task_provider.h
(right):

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
chrome/browser/task_manager/providers/arc/arc_process_task_provider.h:69:
ArcProcessWhitelist whitelist_;
nit: can you add a comment for consistency with the surrounding code?

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
File chrome/browser/task_manager/providers/arc/arc_process_whitelist.cc (right):

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
chrome/browser/task_manager/providers/arc/arc_process_whitelist.cc:14: }
nit: // namespace

(also, add a blank line above).

[Eliot Courtney, 2017-01-25 02:08:12]

Thanks for the comments.

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
File chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc
(right):

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
chrome/browser/task_manager/providers/arc/arc_process_task_provider.cc:64: if
(!whitelist_.ShouldDisplayProcess(entry))
On 2017/01/24 17:09:41, Luis Héctor Chávez wrote:
> this does not look very whitelist-y to me :P (otherwise it would be something
> along the lines of "if in whitelist, always add it").
> 
> how about calling it ArcProcessFilter instead?

Yeah, good point. Done.

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
File chrome/browser/task_manager/providers/arc/arc_process_task_provider.h
(right):

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
chrome/browser/task_manager/providers/arc/arc_process_task_provider.h:69:
ArcProcessWhitelist whitelist_;
On 2017/01/24 17:09:41, Luis Héctor Chávez wrote:
> nit: can you add a comment for consistency with the surrounding code?

Done.

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
File chrome/browser/task_manager/providers/arc/arc_process_whitelist.cc (right):

https://codereview.chromium.org/2655633002/diff/1/chrome/browser/task_manager...
chrome/browser/task_manager/providers/arc/arc_process_whitelist.cc:14: }
On 2017/01/24 17:09:41, Luis Héctor Chávez wrote:
> nit: // namespace
> 
> (also, add a blank line above).

Done.

[Luis Héctor Chávez, 2017-01-26 17:55:13]

few more nits, but lgtm.

</drive-by>

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
File chrome/browser/task_manager/providers/arc/arc_process_filter.h (right):

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_filter.h:23: explicit
ArcProcessFilter(std::set<std::string>&& whitelist);
Given that you will only use the non-default constructor in tests, how about
dropping this one since std::set<std::string> is copiable?

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_filter.h:30:
std::set<std::string> whitelist_;
nit: const

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
File chrome/browser/task_manager/providers/arc/arc_process_task_provider.h
(right):

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_task_provider.h:71:
ArcProcessFilter process_filter_;
nit: const

[Eliot Courtney, 2017-01-30 07:48:54]

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
File chrome/browser/task_manager/providers/arc/arc_process_filter.h (right):

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_filter.h:23: explicit
ArcProcessFilter(std::set<std::string>&& whitelist);
On 2017/01/26 17:55:13, Luis Héctor Chávez wrote:
> Given that you will only use the non-default constructor in tests, how about
> dropping this one since std::set<std::string> is copiable?

Done.

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_filter.h:30:
std::set<std::string> whitelist_;
On 2017/01/26 17:55:13, Luis Héctor Chávez wrote:
> nit: const

Done.

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
File chrome/browser/task_manager/providers/arc/arc_process_task_provider.h
(right):

https://codereview.chromium.org/2655633002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_task_provider.h:71:
ArcProcessFilter process_filter_;
On 2017/01/26 17:55:13, Luis Héctor Chávez wrote:
> nit: const

Done.

[Eliot Courtney, 2017-01-30 07:49:11]

The CQ bit was checked by edcourtney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 07:49:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 08:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 08:51:35]

Dry run: This issue passed the CQ dry run.

[Eliot Courtney, 2017-01-30 08:55:00]

The CQ bit was checked by edcourtney@chromium.org

[Eliot Courtney, 2017-01-30 08:55:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2655633002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-01-30 08:55:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 09:01:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 09:01:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eliot Courtney, 2017-01-30 09:04:54]

Hi Nick, could you review for owners please? Thanks~!

[ncarter (slow), 2017-02-01 17:32:58]

very clean; lgtm -- sorry for the delay in reviewing this

https://codereview.chromium.org/2655633002/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/providers/arc/arc_process_filter.cc (right):

https://codereview.chromium.org/2655633002/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_filter.cc:32: return true;
Add a comment here that provides an overview of the criteria by which processes
should be shown (i.e. what's the strategy here?).

[Eliot Courtney, 2017-02-02 03:46:31]

Think I got a rebase caught up in this patch set. I only changed
arc_process_filter.c. Sorry about that.

https://codereview.chromium.org/2655633002/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/providers/arc/arc_process_filter.cc (right):

https://codereview.chromium.org/2655633002/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/providers/arc/arc_process_filter.cc:32: return true;
On 2017/02/01 17:32:58, ncarter wrote:
> Add a comment here that provides an overview of the criteria by which
processes
> should be shown (i.e. what's the strategy here?).

Good point. Done.

[Eliot Courtney, 2017-02-07 06:11:23]

The CQ bit was checked by edcourtney@chromium.org

[Eliot Courtney, 2017-02-07 06:11:23]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2655633002/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-02-07 06:11:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 06:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 06:13:51]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eliot Courtney, 2017-02-07 07:44:13]

The CQ bit was checked by edcourtney@chromium.org

[commit-bot: I haz the power, 2017-02-07 07:44:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 10:11:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486453453805250,
"parent_rev": "c50e876921535e569078385a0d022cdd8b15a8e7", "commit_rev":
"13452f1a1149352dc13b53027bbceac54ed217e6"}

[commit-bot: I haz the power, 2017-02-07 10:11:47]

Description was changed from

==========
[task_manager] Add ARC process whitelist.

Filter which Android processes we display in the task manager by an
explicit whitelist and based on ProcessState.

BUG=654564
==========

to

==========
[task_manager] Add ARC process whitelist.

Filter which Android processes we display in the task manager by an
explicit whitelist and based on ProcessState.

BUG=654564

Review-Url: https://codereview.chromium.org/2655633002
Cr-Commit-Position: refs/heads/master@{#448580}
Committed:
https://chromium.googlesource.com/chromium/src/+/13452f1a1149352dc13b53027bbc...
==========

[commit-bot: I haz the power, 2017-02-07 10:11:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/13452f1a1149352dc13b53027bbc...