|
|
Created:
3 years, 11 months ago by Yoshisato Yanagisawa Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake no-compile test output sorted with test name.
To make no-compile test deterministic, we also need to make the test
name shown in the same order.
Since I thought order of test names are not important, let me sort it
before printed.
Note that this change may make swarming to ignore executing tests even if
somebody edit *.nc. However, I think the actual tests for non-compile
tests have already done in compile step and build would fail if test
failed, executing generated should not be needed for each *.nc update.
BUG=678903, 105388
Review-Url: https://codereview.chromium.org/2655613002
Cr-Commit-Position: refs/heads/master@{#446018}
Committed: https://chromium.googlesource.com/chromium/src/+/c6d96b97b1b706d165d68d5ee0a4f60b6e12bd00
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
yyanagisawa@chromium.org changed reviewers: + dcheng@chromium.org, thakis@chromium.org, wychen@chromium.org
The CQ bit was checked by yyanagisawa@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM Yes, I believe that should be the case: as long as we still rebuild, the tests will still run.
The CQ bit was checked by yyanagisawa@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Make no-compile test output sorted with test name. To make no-compile test deterministic, we also need to make the test name shown in the same order. Since I thought order of test names are not important, let me sort it before printed. Note that this change may make swarming to ignore executing tests even if somebody edit *.nc. However, I think the actual tests for non-compile tests have already done in compile step and build would fail if test failed, executing generated should not be needed for each *.nc update. BUG=678903 ========== to ========== Make no-compile test output sorted with test name. To make no-compile test deterministic, we also need to make the test name shown in the same order. Since I thought order of test names are not important, let me sort it before printed. Note that this change may make swarming to ignore executing tests even if somebody edit *.nc. However, I think the actual tests for non-compile tests have already done in compile step and build would fail if test failed, executing generated should not be needed for each *.nc update. BUG=678903 ==========
yyanagisawa@chromium.org changed required reviewers: + thakis@chromium.org
I need owner LGTM.
Description was changed from ========== Make no-compile test output sorted with test name. To make no-compile test deterministic, we also need to make the test name shown in the same order. Since I thought order of test names are not important, let me sort it before printed. Note that this change may make swarming to ignore executing tests even if somebody edit *.nc. However, I think the actual tests for non-compile tests have already done in compile step and build would fail if test failed, executing generated should not be needed for each *.nc update. BUG=678903 ========== to ========== Make no-compile test output sorted with test name. To make no-compile test deterministic, we also need to make the test name shown in the same order. Since I thought order of test names are not important, let me sort it before printed. Note that this change may make swarming to ignore executing tests even if somebody edit *.nc. However, I think the actual tests for non-compile tests have already done in compile step and build would fail if test failed, executing generated should not be needed for each *.nc update. BUG=678903,105388 ==========
lgtm wychen: still think this is worth all the toil?
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1485355761096720, "parent_rev": "5179f42d65e1e17e8d9a89906fd533352f101f5a", "commit_rev": "c6d96b97b1b706d165d68d5ee0a4f60b6e12bd00"}
Message was sent while issue was closed.
Description was changed from ========== Make no-compile test output sorted with test name. To make no-compile test deterministic, we also need to make the test name shown in the same order. Since I thought order of test names are not important, let me sort it before printed. Note that this change may make swarming to ignore executing tests even if somebody edit *.nc. However, I think the actual tests for non-compile tests have already done in compile step and build would fail if test failed, executing generated should not be needed for each *.nc update. BUG=678903,105388 ========== to ========== Make no-compile test output sorted with test name. To make no-compile test deterministic, we also need to make the test name shown in the same order. Since I thought order of test names are not important, let me sort it before printed. Note that this change may make swarming to ignore executing tests even if somebody edit *.nc. However, I think the actual tests for non-compile tests have already done in compile step and build would fail if test failed, executing generated should not be needed for each *.nc update. BUG=678903,105388 Review-Url: https://codereview.chromium.org/2655613002 Cr-Commit-Position: refs/heads/master@{#446018} Committed: https://chromium.googlesource.com/chromium/src/+/c6d96b97b1b706d165d68d5ee0a4... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c6d96b97b1b706d165d68d5ee0a4...
Message was sent while issue was closed.
On 2017/01/25 14:49:16, Nico wrote: > lgtm > > wychen: still think this is worth all the toil? Well, less so, and hopefully the amount of work to support nocompile tests would attenuate soon. |