Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2655613002: Make no-compile test output sorted with test name. (Closed)

Created:
3 years, 11 months ago by Yoshisato Yanagisawa
Modified:
3 years, 10 months ago
Reviewers:
*Nico, dcheng, wychen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make no-compile test output sorted with test name. To make no-compile test deterministic, we also need to make the test name shown in the same order. Since I thought order of test names are not important, let me sort it before printed. Note that this change may make swarming to ignore executing tests even if somebody edit *.nc. However, I think the actual tests for non-compile tests have already done in compile step and build would fail if test failed, executing generated should not be needed for each *.nc update. BUG=678903, 105388 Review-Url: https://codereview.chromium.org/2655613002 Cr-Commit-Position: refs/heads/master@{#446018} Committed: https://chromium.googlesource.com/chromium/src/+/c6d96b97b1b706d165d68d5ee0a4f60b6e12bd00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/nocompile_driver.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Yoshisato Yanagisawa
3 years, 11 months ago (2017-01-24 06:10:16 UTC) #2
dcheng
LGTM Yes, I believe that should be the case: as long as we still rebuild, ...
3 years, 11 months ago (2017-01-24 07:56:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655613002/1
3 years, 11 months ago (2017-01-25 03:58:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/349602)
3 years, 11 months ago (2017-01-25 04:06:34 UTC) #11
Yoshisato Yanagisawa
I need owner LGTM.
3 years, 11 months ago (2017-01-25 04:09:14 UTC) #14
Nico
lgtm wychen: still think this is worth all the toil?
3 years, 11 months ago (2017-01-25 14:49:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655613002/1
3 years, 11 months ago (2017-01-25 14:49:43 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c6d96b97b1b706d165d68d5ee0a4f60b6e12bd00
3 years, 11 months ago (2017-01-25 14:59:12 UTC) #21
wychen
3 years, 10 months ago (2017-02-01 02:16:47 UTC) #22
Message was sent while issue was closed.
On 2017/01/25 14:49:16, Nico wrote:
> lgtm
> 
> wychen: still think this is worth all the toil?

Well, less so, and hopefully the amount of work to support nocompile tests would
attenuate soon.

Powered by Google App Engine
This is Rietveld 408576698