MD Settings: Certificates: Add 'Import and bind' button for CrOS

MD Settings: Certificates: Add 'Import and bind' button for CrOS

BUG=600468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2655583002
Cr-Commit-Position: refs/heads/master@{#446476}
Committed: https://chromium.googlesource.com/chromium/src/+/e937aad8f28e9973a1fd947833f76a53a207ec97

[stevenjb, 2017-01-24 02:44:38]

Description was changed from

==========
MD Settings: Certificates: Add 'Import and bind' button

BUG=600468
==========

to

==========
MD Settings: Certificates: Add 'Import and bind' button

BUG=600468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-24 03:09:42]

Description was changed from

==========
MD Settings: Certificates: Add 'Import and bind' button

BUG=600468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Certificates: Add 'Import and bind' button for CrOS

BUG=600468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-24 03:09:47]

stevenjb@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2017-01-24 22:25:14]

Can you attach a screenshot?

[dpapad, 2017-01-24 23:16:03]

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/certificate_manager_page_test.js (right):

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:122: return
Promise.resolve(true);
This should be 
return Promise.resolve(this.useHardwareBacked);

Then you can assert whether 'importPersonalCertificate' was called with the
right parameters from your test. (See related comment below).

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:806: * @param
{boolean=} opt_bind Whether to click on the import and bind btn.
Can we make this parameter required? All calls are in this file, so updating
them should be fairly trivial.

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:830:
proxyMethodName != 'importPersonalCertificate' ||
Don't fully understand this assertion. Can you explain what does it check?
Shouldn't we be checking what argument (true/false) was passed to the browser
instead?

How about the following 

return browserProxy.whenCalled(proxyMethodName).then(function(arg) {
 if (proxyMethodName == 'importPersonalCertificate') {
   assertEquals(arg, opt_bind);
 }
 return waitForActionEvent;
}).then(...)

[stevenjb, 2017-01-25 19:18:49]

On 2017/01/24 23:16:03, dpapad wrote:
>
https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
> File chrome/test/data/webui/settings/certificate_manager_page_test.js (right):
> 
>
https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
> chrome/test/data/webui/settings/certificate_manager_page_test.js:122: return
> Promise.resolve(true);
> This should be 
> return Promise.resolve(this.useHardwareBacked);
> 
> Then you can assert whether 'importPersonalCertificate' was called with the
> right parameters from your test. (See related comment below).
> 
>
https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
> chrome/test/data/webui/settings/certificate_manager_page_test.js:806: * @param
> {boolean=} opt_bind Whether to click on the import and bind btn.
> Can we make this parameter required? All calls are in this file, so updating
> them should be fairly trivial.
> 
>
https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
> chrome/test/data/webui/settings/certificate_manager_page_test.js:830:
> proxyMethodName != 'importPersonalCertificate' ||
> Don't fully understand this assertion. Can you explain what does it check?
> Shouldn't we be checking what argument (true/false) was passed to the browser
> instead?
> 
> How about the following 
> 
> return browserProxy.whenCalled(proxyMethodName).then(function(arg) {
>  if (proxyMethodName == 'importPersonalCertificate') {
>    assertEquals(arg, opt_bind);
>  }
>  return waitForActionEvent;
> }).then(...)

Screenshot: https://screenshot.googleplex.com/OGNQ6cTsdJn.png

[stevenjb, 2017-01-25 19:39:36]

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/certificate_manager_page_test.js (right):

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:122: return
Promise.resolve(true);
On 2017/01/24 23:16:03, dpapad wrote:
> This should be 
> return Promise.resolve(this.useHardwareBacked);
> 
> Then you can assert whether 'importPersonalCertificate' was called with the
> right parameters from your test. (See related comment below). 

Actually, useHardwareBacked can be passed to methodCalled; 'true' is the return
value of importPersonalCertificate (whether to show a password prompt). The test
expects that to be true.

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:806: * @param
{boolean=} opt_bind Whether to click on the import and bind btn.
On 2017/01/24 23:16:03, dpapad wrote:
> Can we make this parameter required? All calls are in this file, so updating
> them should be fairly trivial.

Noisy change imho, but sure.

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:830:
proxyMethodName != 'importPersonalCertificate' ||
On 2017/01/24 23:16:03, dpapad wrote:
> Don't fully understand this assertion. Can you explain what does it check?
> Shouldn't we be checking what argument (true/false) was passed to the browser
> instead?
> 
> How about the following 
> 
> return browserProxy.whenCalled(proxyMethodName).then(function(arg) {
>  if (proxyMethodName == 'importPersonalCertificate') {
>    assertEquals(arg, opt_bind);
>  }
>  return waitForActionEvent;
> }).then(...)

Done.

[dpapad, 2017-01-25 21:14:00]

LGTM

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/certificate_manager_page_test.js (right):

https://codereview.chromium.org/2655583002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:122: return
Promise.resolve(true);
On 2017/01/25 at 19:39:35, stevenjb wrote:
> On 2017/01/24 23:16:03, dpapad wrote:
> > This should be 
> > return Promise.resolve(this.useHardwareBacked);
> > 
> > Then you can assert whether 'importPersonalCertificate' was called with the
> > right parameters from your test. (See related comment below). 
> 
> Actually, useHardwareBacked can be passed to methodCalled; 'true' is the
return value of importPersonalCertificate (whether to show a password prompt).
The test expects that to be true.

Ah you are right. That is what I origanaly meant, but confused the return value
and the methodCalled params in my suggestion.

[stevenjb, 2017-01-25 21:24:41]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-01-25 21:25:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:52:55]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[stevenjb, 2017-01-25 23:01:32]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:03:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 00:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 00:39:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-01-26 19:59:50]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-01-26 19:59:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2655583002/#ps80001
(title: "Elim OS_CHROMEOS condition for certificateManagerImportAndBind to fix
tests")

[commit-bot: I haz the power, 2017-01-26 20:00:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 22:48:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485460790807010,
"parent_rev": "0c86c2cc59ffd8a299539f76a03211447d8bf893", "commit_rev":
"e937aad8f28e9973a1fd947833f76a53a207ec97"}

[commit-bot: I haz the power, 2017-01-26 22:48:51]

Description was changed from

==========
MD Settings: Certificates: Add 'Import and bind' button for CrOS

BUG=600468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Certificates: Add 'Import and bind' button for CrOS

BUG=600468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2655583002
Cr-Commit-Position: refs/heads/master@{#446476}
Committed:
https://chromium.googlesource.com/chromium/src/+/e937aad8f28e9973a1fd947833f7...
==========

[commit-bot: I haz the power, 2017-01-26 22:48:52]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e937aad8f28e9973a1fd947833f7...