Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2655573003: Fix crash in EnrollmentScreenHandler for Active Directory devices. (Closed)

Created:
3 years, 11 months ago by Roman Sorokin (ftl)
Modified:
3 years, 11 months ago
Reviewers:
Thiemo Nagel, achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, Thiemo Nagel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in EnrollmentScreenHandler for Active Directory devices. BUG=682779 TEST=manual Review-Url: https://codereview.chromium.org/2655573003 Cr-Commit-Position: refs/heads/master@{#445788} Committed: https://chromium.googlesource.com/chromium/src/+/a36717f4c79513664b45ba0248ebd731cf6e3e0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Roman Sorokin (ftl)
Hey Achuith, PTAL. Thanks!
3 years, 11 months ago (2017-01-24 12:16:48 UTC) #4
Roman Sorokin (ftl)
3 years, 11 months ago (2017-01-24 17:20:21 UTC) #7
achuithb
lgtm
3 years, 11 months ago (2017-01-24 19:43:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655573003/1
3 years, 11 months ago (2017-01-24 19:55:29 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 20:01:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a36717f4c79513664b45ba0248eb...

Powered by Google App Engine
This is Rietveld 408576698