Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2655553006: add post-mortem metadata for frames type (Closed)

Created:
3 years, 11 months ago by julien.gilli
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

add post-mortem metadata for frames type Previously (and still currently for some of them), post-mortem debugging tools were using StandardFrameConstants::kContextOffset as the offset to get the value that represents a frame's type. However since https://codereview.chromium.org/1696043002, a new, more general offset was introduced: CommonFrameConstants::kContextOrFrameTypeOffset. In order for post-mortem debugging tools to use this constant, it is included in the generated post-mortem metadata. R=danno@chromium.org,bmeurer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2655553006 Cr-Commit-Position: refs/heads/master@{#42746} Committed: https://chromium.googlesource.com/v8/v8/+/cd96c7ccd5feb26337d921dd13b29877b87d2910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-01-27 08:23:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655553006/1
3 years, 10 months ago (2017-01-27 17:57:27 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 18:19:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cd96c7ccd5feb26337d921dd13b29877b87...

Powered by Google App Engine
This is Rietveld 408576698