Issue 2655533005: Revert of ShapeDetection: use mojom::Bitmap for mojo interface.

Issue 2655533005: Revert of ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)

Created:
3 years, 11 months ago by maniscalco

Modified:
3 years, 11 months ago

Reviewers:
dominickn, Ken Rockot(use gerrit already), aelias_OOO_until_Jul13, mlamouri (slow - plz ping), David Trainor- moved to gerrit, timvolodine, haraken, leonhsl(Using Gerrit), mcasas, yzshen1, xianglu, Tom Sepez, Ben Goodger (Google), junwei

CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #5 id:280001 of https://codereview.chromium.org/2629433003/ ) Reason for revert: Suspected of breaking the build: https://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds/81497 Original issue's description: > ShapeDetection: use mojom::Bitmap for mojo interface. > > This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, > so that the Detect API is completely flexible and friendly. > > BUG=665488 > TEST(Layout)= > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html > > Review-Url: https://codereview.chromium.org/2629433003 > Cr-Commit-Position: refs/heads/master@{#446142} > Committed: https://chromium.googlesource.com/chromium/src/+/33adf4c85dd553eb607bcf9c02c5fa60c8738a68 TBR=rockot@chromium.org,aelias@chromium.org,ben@chromium.org,dominickn@chromium.org,dtrainor@chromium.org,haraken@chromium.org,leon.han@intel.com,mcasas@chromium.org,mlamouri@chromium.org,timvolodine@chromium.org,tsepez@chromium.org,xianglu@chromium.org,yzshen@chromium.org,junwei.fu@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665488 Review-Url: https://codereview.chromium.org/2655533005 Cr-Commit-Position: refs/heads/master@{#446145} Committed: https://chromium.googlesource.com/chromium/src/+/2a78436aaa2277759c1d9f11b719b72cb95456b4

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -125 lines)			Patch
M	AUTHORS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/android/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java	View	4 chunks	+6 lines, -16 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java	View	4 chunks	+6 lines, -16 lines	0 comments	Download
M	content/public/android/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java	View	2 chunks	+11 lines, -23 lines	0 comments	Download
M	services/shape_detection/public/interfaces/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	services/shape_detection/public/interfaces/barcodedetection.mojom	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	services/shape_detection/public/interfaces/facedetection.mojom	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	services/shape_detection/public/interfaces/textdetection.mojom	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/FaceDetector.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp	View	5 chunks	+59 lines, -33 lines	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/TextDetector.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp	View	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

maniscalco

Created Revert of ShapeDetection: use mojom::Bitmap for mojo interface.

3 years, 11 months ago (2017-01-25 22:38:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655533005/1

3 years, 11 months ago (2017-01-25 22:39:51 UTC) #3

commit-bot: I haz the power

Description was changed from ========== Revert of ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #5 ...

3 years, 11 months ago (2017-01-25 22:43:10 UTC) #5

Message was sent while issue was closed.

Description was changed from

==========
Revert of ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #5
id:280001 of https://codereview.chromium.org/2629433003/ )

Reason for revert:
Suspected of breaking the build:
https://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds...

Original issue's description:
> ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
> so that the Detect API is completely flexible and friendly.
>     
> BUG=665488
> TEST(Layout)=
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
> 
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
> 
> Review-Url: https://codereview.chromium.org/2629433003
> Cr-Commit-Position: refs/heads/master@{#446142}
> Committed:
https://chromium.googlesource.com/chromium/src/+/33adf4c85dd553eb607bcf9c02c5...

TBR=rockot@chromium.org,aelias@chromium.org,ben@chromium.org,dominickn@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=665488
==========

to

==========
Revert of ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #5
id:280001 of https://codereview.chromium.org/2629433003/ )

Reason for revert:
Suspected of breaking the build:
https://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds...

Original issue's description:
> ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
> so that the Detect API is completely flexible and friendly.
>     
> BUG=665488
> TEST(Layout)=
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
> 
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
> 
> Review-Url: https://codereview.chromium.org/2629433003
> Cr-Commit-Position: refs/heads/master@{#446142}
> Committed:
https://chromium.googlesource.com/chromium/src/+/33adf4c85dd553eb607bcf9c02c5...

TBR=rockot@chromium.org,aelias@chromium.org,ben@chromium.org,dominickn@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=665488

Review-Url: https://codereview.chromium.org/2655533005
Cr-Commit-Position: refs/heads/master@{#446145}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a78436aaa2277759c1d9f11b719...
==========

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2a78436aaa2277759c1d9f11b719b72cb95456b4

3 years, 11 months ago (2017-01-25 22:43:14 UTC) #6

maniscalco

3 years, 11 months ago (2017-01-25 22:46:42 UTC) #7

Message was sent while issue was closed.

On 2017/01/25 22:43:14, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/2a78436aaa2277759c1d9f11b719...

More details in https://bugs.chromium.org/p/chromium/issues/detail?id=685398

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages