Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2655533004: [tests] Fix use-after-scope errors related to weak refs (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Fix use-after-scope errors related to weak refs BUG=v8:5887 Review-Url: https://codereview.chromium.org/2655533004 Cr-Commit-Position: refs/heads/master@{#42652} Committed: https://chromium.googlesource.com/v8/v8/+/f392922b4a76c9e55139674490222ed838320a6d

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M test/cctest/test-api.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Michael Lippautz
ptal
3 years, 11 months ago (2017-01-25 08:23:26 UTC) #3
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-25 08:33:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655533004/20001
3 years, 11 months ago (2017-01-25 10:44:06 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 10:46:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f392922b4a76c9e55139674490222ed8383...

Powered by Google App Engine
This is Rietveld 408576698