Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2655533003: [turbofan] Remove dead {is_liveness_analysis_enabled}. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 10 months ago
Reviewers:
Jarin, Leszek Swirski
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove dead {is_liveness_analysis_enabled}. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2655533003 Cr-Commit-Position: refs/heads/master@{#42693} Committed: https://chromium.googlesource.com/v8/v8/+/01d051ff33d9dbaa5d280a7a623e3c093c0e6bd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael Starzinger
Jaro: PTAL. Leszek: FYI.
3 years, 11 months ago (2017-01-24 12:15:16 UTC) #4
Leszek Swirski
I could add this functionality to the bytecode analysis if you think it's useful?
3 years, 10 months ago (2017-01-24 19:53:15 UTC) #7
Michael Starzinger
On 2017/01/24 19:53:15, Leszek Swirski wrote: > I could add this functionality to the bytecode ...
3 years, 10 months ago (2017-01-25 09:12:11 UTC) #8
Leszek Swirski
On 2017/01/25 09:12:11, Michael Starzinger wrote: > On 2017/01/24 19:53:15, Leszek Swirski wrote: > > ...
3 years, 10 months ago (2017-01-25 17:33:36 UTC) #9
Jarin
lgtm
3 years, 10 months ago (2017-01-26 10:20:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655533003/1
3 years, 10 months ago (2017-01-26 11:51:36 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 12:24:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/01d051ff33d9dbaa5d280a7a623e3c093c0...

Powered by Google App Engine
This is Rietveld 408576698