Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2655503002: Revert of [chromedriver] Prevent GetLog from returning more than 100,000 at a time. (Closed)

Created:
3 years, 11 months ago by waffles
Modified:
3 years, 11 months ago
Reviewers:
samuong, stgao, klm
CC:
chromium-reviews, samuong+watch_chromium.org, ahbeng_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [chromedriver] Prevent GetLog from returning more than 100,000 at a time. (patchset #2 id:20001 of https://codereview.chromium.org/2644033004/ ) Reason for revert: Consistently causes test timeouts in Logging.GetLotsOfLogs of Mac 10.9 [ RUN ] Logging.GetLotsOfLogs [240/240] Logging.GetLotsOfLogs (TIMED OUT) https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/35478 Original issue's description: > [chromedriver] Prevent GetLog from returning more than 100,000 at a time. > > BUG=681892 > > Review-Url: https://codereview.chromium.org/2644033004 > Cr-Commit-Position: refs/heads/master@{#445429} > Committed: https://chromium.googlesource.com/chromium/src/+/ea5734bd3270765de34fc7f37b64759fe1d1c1bd TBR=stgao@chromium.org,klm@google.com,samuong@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681892 Review-Url: https://codereview.chromium.org/2655503002 Cr-Commit-Position: refs/heads/master@{#445480} Committed: https://chromium.googlesource.com/chromium/src/+/8071d70e62d7c427491aa5e268b5f09dc887cca9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -34 lines) Patch
M chrome/test/chromedriver/logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/chromedriver/logging.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M chrome/test/chromedriver/logging_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
waffles
Created Revert of [chromedriver] Prevent GetLog from returning more than 100,000 at a time.
3 years, 11 months ago (2017-01-23 20:56:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655503002/1
3 years, 11 months ago (2017-01-23 20:57:08 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:58:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8071d70e62d7c427491aa5e268b5...

Powered by Google App Engine
This is Rietveld 408576698