Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2655483002:
MD Settings: Fix long username breaking layout in manage-password page. (Closed)
|
Created:
3 years, 11 months ago by scottchen Modified:
3 years, 10 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Fix long username breaking layout in manage-password page.
BUG=619777
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2655483002
Cr-Commit-Position: refs/heads/master@{#446879}
Committed: https://chromium.googlesource.com/chromium/src/+/274ea861440c642cd4180cffe937c6cb42342aee
Patch Set 1 #Patch Set 2 : Merge branch 'master' into passwords #Messages
Total messages: 26 (14 generated)
Description was changed from ========== MD Settings: Fix long username breaking layout in manage-password page. BUG=619777 ========== to ========== MD Settings: Fix long username breaking layout in manage-password page. BUG=619777 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
scottchen@chromium.org changed reviewers: + dpapad@chromium.org, dschuyler@chromium.org
On 2017/01/23 20:23:08, scottchen wrote: screenshot after fix: http://imgur.com/a/vxJx4
lgtm
On 2017/01/23 at 21:39:49, dschuyler wrote: > lgtm Posted some thoughts at https://bugs.chromium.org/p/chromium/issues/detail?id=619777#c8. I am not 100% sure that cutting off the username without any option of seeing the cut off text is the best experience.
On 2017/01/23 22:17:58, dpapad wrote: > On 2017/01/23 at 21:39:49, dschuyler wrote: > > lgtm > > Posted some thoughts at > https://bugs.chromium.org/p/chromium/issues/detail?id=619777#c8. I am not 100% > sure that cutting off the username without any option of seeing the cut off text > is the best experience. Updated comments in the bug as well. I believe the overflow menu's "view details" option provides a reasonable way for user to see their long username if they really wish to see the full thing.
The CQ bit was checked by scottchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/01/23 at 23:21:53, scottchen wrote: > On 2017/01/23 22:17:58, dpapad wrote: > > On 2017/01/23 at 21:39:49, dschuyler wrote: > > > lgtm > > > > Posted some thoughts at > > https://bugs.chromium.org/p/chromium/issues/detail?id=619777#c8. I am not 100% > > sure that cutting off the username without any option of seeing the cut off text > > is the best experience. > > Updated comments in the bug as well. I believe the overflow menu's "view details" option provides a reasonable way for user to see their long username if they really wish to see the full thing. LGTM given @bettes comment at https://bugs.chromium.org/p/chromium/issues/detail?id=619777#c16. I am assuming that a similar fix needs to be made for the URL though?
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:
While running git apply --index -p1;
error: patch failed:
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:88
error:
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:
patch does not apply
Patch:
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
Index:
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git
a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index
f3073fbdae0fae0fab8f88335cf162b9ec334c0e..305899eb8c869637edfc0dc10254c14b29f1d923
100644
---
a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++
b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -88,7 +88,7 @@
<a id="originUrl" target="_blank" class="selectable"
href="[[item.linkUrl]]">[[item.loginPair.originUrl]]</a>
</div>
- <div class="username-column selectable"
+ <div class="username-column selectable text-elide"
id="username">[[item.loginPair.username]]</div>
<div class="password-column">
<!-- Password type and disabled in order to match mock. -->
The CQ bit was checked by scottchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dschuyler@chromium.org, dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2655483002/#ps20001 (title: "Merge branch 'master' into passwords")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485557528627750,
"parent_rev": "6f2db51fbe14e281613fa054a650a314464125e1", "commit_rev":
"274ea861440c642cd4180cffe937c6cb42342aee"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix long username breaking layout in manage-password page. BUG=619777 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix long username breaking layout in manage-password page. BUG=619777 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2655483002 Cr-Commit-Position: refs/heads/master@{#446879} Committed: https://chromium.googlesource.com/chromium/src/+/274ea861440c642cd4180cffe937... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/274ea861440c642cd4180cffe937... |
