components/test_runner/event_sender.cc - Issue 2655463015: Correctly set dragLeave and dragEnd coords for OOPIF drag and drop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/event_sender.cc

Issue 2655463015: Correctly set dragLeave and dragEnd coords for OOPIF drag and drop (Closed)

Patch Set: Added checks for null RWH on drag end Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/event_sender.cc

diff --git a/components/test_runner/event_sender.cc b/components/test_runner/event_sender.cc

index 7f38826f9b52e91b910257135d2fa7d2086bdb54..24f62b0d6493cd4c53d1a4b670076e399069a6a8 100644

--- a/components/test_runner/event_sender.cc

+++ b/components/test_runner/event_sender.cc

@@ -2689,7 +2689,8 @@ void EventSender::FinishDragAndDrop(const WebMouseEvent& raw_event,

mainFrameWidget()->dragTargetDrop(current_drag_data_, client_point,

screen_point, event->modifiers());

} else {

- mainFrameWidget()->dragTargetDragLeave();

+ mainFrameWidget()->dragTargetDragLeave(blink::WebPoint(),

+ blink::WebPoint());

}

current_drag_data_.reset();

mainFrameWidget()->dragSourceEndedAt(client_point, screen_point,