Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc

Issue 2655463015: Correctly set dragLeave and dragEnd coords for OOPIF drag and drop (Closed)
Patch Set: Added checks for null RWH on drag end Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/test_runner/event_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc b/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
index 91bba25caf4462571acd2f4933a72d893487717f..2dd441415de855197114de8fcc210c98df775dbc 100644
--- a/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
+++ b/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
@@ -934,12 +934,8 @@ void DragAndDropBrowserTest::DragImageBetweenFrames_Step2(
{ // Verify dragleave DOM event.
std::string dragleave_event;
- // TODO(paulmeyer): https://crbug.com/669695: Need to unify coordinates
- // passed to dragend when OOPIFs are present or not.
- state->expected_dom_event_data.set_expected_client_position(
- "<no expectation>");
- state->expected_dom_event_data.set_expected_page_position(
- "<no expectation>");
+ state->expected_dom_event_data.set_expected_client_position("(355, 150)");
+ state->expected_dom_event_data.set_expected_page_position("(355, 150)");
EXPECT_TRUE(
dragleave_event_waiter.WaitForNextMatchingEvent(&dragleave_event));
@@ -1025,8 +1021,8 @@ void DragAndDropBrowserTest::DragImageBetweenFrames_Step3(
state->expected_dom_event_data.set_expected_drop_effect("copy");
state->expected_dom_event_data.set_expected_mime_types("");
- // TODO(paulmeyer): https://crbug.com/669695: Need to unify coordinates
- // passed to dragend when OOPIFs are present or not.
+ // TODO: https://crbug.com/686136: dragEnd coordinates for non-OOPIF
+ // scenarios are currently broken.
state->expected_dom_event_data.set_expected_client_position(
"<no expectation>");
state->expected_dom_event_data.set_expected_page_position(
« no previous file with comments | « no previous file | components/test_runner/event_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698