Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2655463010: [MD settings] correct label for policy controlled flash settings (Closed)

Created:
3 years, 10 months ago by dschuyler
Modified:
3 years, 10 months ago
Reviewers:
scottchen
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] correct label for policy controlled flash settings This CL moves the category-default-setting away from using the computeCategoryDesc() function to determine toggle labels. This fixes an issue where the flash toggle was showing the incorrect label. BUG=684120 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2655463010 Cr-Commit-Position: refs/heads/master@{#446389} Committed: https://chromium.googlesource.com/chromium/src/+/84c9557cefe7c58e1fc6f887621ce9d5d7e269c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 12 chunks +32 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/category_default_setting.js View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 10 months ago (2017-01-25 23:45:42 UTC) #5
scottchen
On 2017/01/25 23:45:42, dschuyler wrote: lgtm
3 years, 10 months ago (2017-01-26 00:51:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655463010/1
3 years, 10 months ago (2017-01-26 18:08:05 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 19:28:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84c9557cefe7c58e1fc6f887621c...

Powered by Google App Engine
This is Rietveld 408576698