Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2655433005: Revert of Reroute Android mouse events to touch event path. (Closed)

Created:
3 years, 11 months ago by mustaq
Modified:
3 years, 11 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, amaralp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reroute Android mouse events to touch event path. (patchset #1 id:1 of https://codereview.chromium.org/2637143002/ ) Reason for revert: The CL being reverted was a temporary fix for M56 & M57, to give us more time to fix the core problems: enable text selection & zoom through mouse (crbug.com/675339). To continue working on those core problem, we need to dispatch mouse events as mouse again. Original issue's description: > Reroute Android mouse events to touch event path. > > This is a partial revert of crrev.com/2054193002 that aimed to > make Android mouse events more logical & consistent. However, > that change made few UI activities impossible through mouse, > like text selection, zoom & scrolling. Until we fix those > for mouse, we are re-diverting mouse events to the touch-event > path through this CL. > > BUG=678756 > > Review-Url: https://codereview.chromium.org/2637143002 > Cr-Commit-Position: refs/heads/master@{#444116} > Committed: https://chromium.googlesource.com/chromium/src/+/8bdf02e2b5552def943a60cf8e078918369df6fe TBR=aelias@chromium.org,rbyers@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=675339 Review-Url: https://codereview.chromium.org/2655433005 Cr-Commit-Position: refs/heads/master@{#446060} Committed: https://chromium.googlesource.com/chromium/src/+/cbfc51271202a15afc7c6797f4eab4052c6a3867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mustaq
Created Revert of Reroute Android mouse events to touch event path.
3 years, 11 months ago (2017-01-25 17:43:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655433005/1
3 years, 11 months ago (2017-01-25 17:44:22 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 18:23:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbfc51271202a15afc7c6797f4ea...

Powered by Google App Engine
This is Rietveld 408576698