Fix expiry time conversion in ContentDecryptorDelegate

Fix expiry time conversion in ContentDecryptorDelegate

Currently we use PPTimeToTime to convert PP_Time (double) to base::Time.
In PPTimeToTime, 0.0 is converted to base::Time::UnixEpoch() instead of
base::Time(), which is a "null" Time.

Now with https://chromiumcodereview.appspot.com/2650033007/, only null
base::Time will be converted to NaN in JavaScript. Therefore, a PP_Time
of 0.0 will be converted to Epoch in JS, which is wrong.

This CL update the code in ContentDecryptorDelegate such that PP_Time
0.0 will be converted to null base::Time.

BUG=679079
TEST=Updated browser and unit test to cover this.

Review-Url: https://codereview.chromium.org/2655413003
Cr-Commit-Position: refs/heads/master@{#447162}
Committed: https://chromium.googlesource.com/chromium/src/+/c54be1be4832bb10b83d43078ccb804cdddbbd14

[xhwang, 2017-01-27 08:31:38]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 08:32:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-01-27 08:40:29]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 08:40:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 09:17:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 09:17:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2017-01-27 17:58:14]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 17:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-01-27 17:59:38]

xhwang@chromium.org changed reviewers:
+ jrummell@chromium.org

[xhwang, 2017-01-27 17:59:39]

More expiry time fix ;)

jrummell: PTAL
ddorwin: FYI

[xhwang, 2017-01-27 18:00:14]

Description was changed from

==========
Fix expiry time conversion in ContentDecryptorDelegate

Currently we use PPTimeToTime to convert PP_Time (double) to base::Time.
In PPTimeToTime, 0.0 is converted to base::Time::UnixEpoch() instead of
base::Time(), which is a "null" Time.

Now with https://chromiumcodereview.appspot.com/2650033007/, only null
base::Time will be converted to NaN in JavaScript. Therefore, a PP_Time
of 0.0 will be converted to Epoch in JS, which is wrong.

This CL update the code in ContentDecryptorDelegate such that PP_Time
0.0 will be converted to null base::Time.

BUG=679079
TEST=Updated browser test to cover this.
==========

to

==========
Fix expiry time conversion in ContentDecryptorDelegate

Currently we use PPTimeToTime to convert PP_Time (double) to base::Time.
In PPTimeToTime, 0.0 is converted to base::Time::UnixEpoch() instead of
base::Time(), which is a "null" Time.

Now with https://chromiumcodereview.appspot.com/2650033007/, only null
base::Time will be converted to NaN in JavaScript. Therefore, a PP_Time
of 0.0 will be converted to Epoch in JS, which is wrong.

This CL update the code in ContentDecryptorDelegate such that PP_Time
0.0 will be converted to null base::Time.

BUG=679079
TEST=Updated browser and unit test to cover this.
==========

[commit-bot: I haz the power, 2017-01-27 18:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:38:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2017-01-27 20:26:38]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 20:27:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jrummell, 2017-01-27 20:40:23]

lgtm

[xhwang, 2017-01-27 20:42:22]

xhwang@chromium.org changed reviewers:
+ bbudge@chromium.org

[xhwang, 2017-01-27 20:42:23]

bbudge@chromium.org: Please review changes in
content/renderer/pepper/content_decryptor_delegate.cc

Time conversion is a mess now, please see BUG and crbug.com/625680 if you are
interested.

[commit-bot: I haz the power, 2017-01-27 22:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 22:46:05]

Dry run: This issue passed the CQ dry run.

[xhwang, 2017-01-30 17:49:57]

bbudge: kindly ping :)

[bbudge, 2017-01-30 23:41:37]

content/renderer/pepper  lgtm

[xhwang, 2017-01-30 23:42:54]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2017-01-30 23:43:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 02:11:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485819774510710,
"parent_rev": "42928bc5f4e7125608a86e33b046a1460d8e576d", "commit_rev":
"c54be1be4832bb10b83d43078ccb804cdddbbd14"}

[commit-bot: I haz the power, 2017-01-31 02:12:26]

Description was changed from

==========
Fix expiry time conversion in ContentDecryptorDelegate

Currently we use PPTimeToTime to convert PP_Time (double) to base::Time.
In PPTimeToTime, 0.0 is converted to base::Time::UnixEpoch() instead of
base::Time(), which is a "null" Time.

Now with https://chromiumcodereview.appspot.com/2650033007/, only null
base::Time will be converted to NaN in JavaScript. Therefore, a PP_Time
of 0.0 will be converted to Epoch in JS, which is wrong.

This CL update the code in ContentDecryptorDelegate such that PP_Time
0.0 will be converted to null base::Time.

BUG=679079
TEST=Updated browser and unit test to cover this.
==========

to

==========
Fix expiry time conversion in ContentDecryptorDelegate

Currently we use PPTimeToTime to convert PP_Time (double) to base::Time.
In PPTimeToTime, 0.0 is converted to base::Time::UnixEpoch() instead of
base::Time(), which is a "null" Time.

Now with https://chromiumcodereview.appspot.com/2650033007/, only null
base::Time will be converted to NaN in JavaScript. Therefore, a PP_Time
of 0.0 will be converted to Epoch in JS, which is wrong.

This CL update the code in ContentDecryptorDelegate such that PP_Time
0.0 will be converted to null base::Time.

BUG=679079
TEST=Updated browser and unit test to cover this.

Review-Url: https://codereview.chromium.org/2655413003
Cr-Commit-Position: refs/heads/master@{#447162}
Committed:
https://chromium.googlesource.com/chromium/src/+/c54be1be4832bb10b83d43078ccb...
==========

[commit-bot: I haz the power, 2017-01-31 02:12:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c54be1be4832bb10b83d43078ccb...