Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2655413002: Convert RenderFrameDevToolsAgentHost to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert RenderFrameDevToolsAgentHost to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2655413002 Cr-Commit-Position: refs/heads/master@{#446522} Committed: https://chromium.googlesource.com/chromium/src/+/9865cb667e579e2cd63214d9a423bf028a4dbd90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -40 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 3 chunks +17 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 11 months ago (2017-01-26 23:34:25 UTC) #5
dgozman
lgtm
3 years, 11 months ago (2017-01-27 00:41:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655413002/1
3 years, 11 months ago (2017-01-27 00:51:18 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 01:23:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9865cb667e579e2cd63214d9a423...

Powered by Google App Engine
This is Rietveld 408576698