Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2655403003: Adjust wasm_serialization_tests.html the layout test to expect null on failure. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
Mircea Trofin
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust wasm_serialization_tests.html the layout test to expect null on failure. BUG=685713 Review-Url: https://codereview.chromium.org/2655403003 Cr-Commit-Position: refs/heads/master@{#446733} Committed: https://chromium.googlesource.com/chromium/src/+/e4dba869a3d98fa911eaba9381e84aaca69057a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/wasm/wasm_serialization_tests.js View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
jbroman
3 years, 10 months ago (2017-01-27 16:52:57 UTC) #4
Mircea Trofin
lgtm
3 years, 10 months ago (2017-01-27 16:57:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655403003/1
3 years, 10 months ago (2017-01-27 16:58:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/352153)
3 years, 10 months ago (2017-01-27 17:06:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655403003/1
3 years, 10 months ago (2017-01-27 17:55:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/352207)
3 years, 10 months ago (2017-01-27 18:04:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655403003/1
3 years, 10 months ago (2017-01-27 19:18:07 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 19:25:27 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4dba869a3d98fa911eaba9381e8...

Powered by Google App Engine
This is Rietveld 408576698