Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2655353003: Fix individual should() assertions to return result (Closed)

Created:
3 years, 11 months ago by hongchan
Modified:
3 years, 11 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

should() assertions are not returning anything after the assertion. The individual result might be useful in some cases. (e.g. branching out based on the assertion result.) BUG=685722 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html Review-Url: https://codereview.chromium.org/2655353003 Cr-Commit-Position: refs/heads/master@{#446499} Committed: https://chromium.googlesource.com/chromium/src/+/c0c860847549025ce4ea31009817a3b8a85d18c6

Patch Set 1 : Initial Commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
hongchan
PTAL.
3 years, 11 months ago (2017-01-26 23:00:21 UTC) #3
Raymond Toy
lgtm
3 years, 11 months ago (2017-01-26 23:10:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655353003/1
3 years, 11 months ago (2017-01-26 23:11:57 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 00:24:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0c860847549025ce4ea31009817...

Powered by Google App Engine
This is Rietveld 408576698