Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2655263004: [tests] Fix assertUnoptimized() when --deopt-every-n-times flag is used. (Closed)

Created:
3 years, 10 months ago by Igor Sheludko
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Fix assertUnoptimized() when --deopt-every-n-times flag is used. Basically, with --deopt-every-n-times flag all bets are off since the functions can be optimized and deoptimized at any time. BUG=v8:5890 Review-Url: https://codereview.chromium.org/2655263004 Cr-Commit-Position: refs/heads/master@{#42735} Committed: https://chromium.googlesource.com/v8/v8/+/c5644146bc4f8725cfba440940590c9a53fab552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M test/mjsunit/mjsunit.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Igor Sheludko
PTAL
3 years, 10 months ago (2017-01-27 11:18:30 UTC) #3
Michael Starzinger
LGTM.
3 years, 10 months ago (2017-01-27 11:24:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655263004/1
3 years, 10 months ago (2017-01-27 11:26:25 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 11:58:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c5644146bc4f8725cfba440940590c9a53f...

Powered by Google App Engine
This is Rietveld 408576698