Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2655253002: Revert of Moved NavigationManagerImpl serialization out of CRWSessionController. (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moved NavigationManagerImpl serialization out of CRWSessionController. (patchset #9 id:160001 of https://codereview.chromium.org/1360993002/ ) Reason for revert: Lot of tests are failing. It seems that sequence_checker_.CalledOnValidSequence() returns false in those cases. Example: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/23584/steps/ios_chrome_integration_egtests%20%28iPhone%206s%20iOS%2010.0%29/logs/HandoffManagerTestCase.testTypicalURLInNewTab Original issue's description: > Moved NavigationManagerImpl serialization out of CRWSessionController. > > - Created CRWNavigationManagerStorage, which holds all the data that > is persisted for a single NavigationManager. It conforms to NSCoding and > is responsible for encoding sessions. A factory method for these objects > as added to WebState's public interface. > - Created NavigationManagerStorageBuilder, which contains functions > to convert between NavigationManagers and > CRWNavigationManagerStorage. > - Changed the relationship between WebStateImpls and > NavigationManagerImpls. Previously, WebStateImpls created empty > NavigationManagerImpls and injected deserialized CRWSessionControllers > into them. Now, WebStateImpls are passed serialized NavigationManagers > upon construction when restoring state. > - SessionWindowIOS's interface is updated to use NavigationManager > serializations rather than WebStateImpls, and SessionWindowIOS clients in > chrome// can use these to create WebStates using CreateParams. > > BUG=454984 > > Review-Url: https://codereview.chromium.org/1360993002 > Cr-Commit-Position: refs/heads/master@{#446279} > Committed: https://chromium.googlesource.com/chromium/src/+/be48752128d7ec4a5bd6d980157deb60dbb29548 TBR=eugenebut@chromium.org,kkhorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454984 Review-Url: https://codereview.chromium.org/2655253002 Cr-Commit-Position: refs/heads/master@{#446294} Committed: https://chromium.googlesource.com/chromium/src/+/75cf0e280ec3d153cfafe7b20d9c0a860bd08c03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -463 lines) Patch
M ios/chrome/browser/crash_report/crash_restore_helper.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M ios/chrome/browser/sessions/session_service.mm View 2 chunks +1 line, -4 lines 0 comments Download
M ios/chrome/browser/sessions/session_service_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/session_window.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ios/chrome/browser/sessions/session_window.mm View 3 chunks +91 lines, -56 lines 0 comments Download
M ios/chrome/browser/sessions/session_window_unittest.mm View 4 chunks +20 lines, -18 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 4 chunks +15 lines, -23 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/web/navigation/crw_session_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 3 chunks +66 lines, -8 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 2 chunks +2 lines, -10 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +8 lines, -10 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 chunk +2 lines, -3 lines 0 comments Download
D ios/web/navigation/navigation_manager_storage_builder.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ios/web/navigation/navigation_manager_storage_builder.mm View 1 chunk +0 lines, -88 lines 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
D ios/web/public/crw_navigation_manager_storage.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ios/web/public/crw_navigation_manager_storage.mm View 1 chunk +0 lines, -88 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/public/test/fakes/test_web_state.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/public/web_state/web_state.h View 3 chunks +0 lines, -9 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 5 chunks +8 lines, -8 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 9 chunks +13 lines, -43 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
gambard
Created Revert of Moved NavigationManagerImpl serialization out of CRWSessionController.
3 years, 11 months ago (2017-01-26 10:22:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655253002/1
3 years, 11 months ago (2017-01-26 10:23:09 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 10:24:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75cf0e280ec3d153cfafe7b20d9c...

Powered by Google App Engine
This is Rietveld 408576698