Chromium Code Reviews
DescriptionRevert of Moved NavigationManagerImpl serialization out of CRWSessionController. (patchset #9 id:160001 of https://codereview.chromium.org/1360993002/ )
Reason for revert:
Lot of tests are failing. It seems that sequence_checker_.CalledOnValidSequence() returns false in those cases.
Example: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/23584/steps/ios_chrome_integration_egtests%20%28iPhone%206s%20iOS%2010.0%29/logs/HandoffManagerTestCase.testTypicalURLInNewTab
Original issue's description:
> Moved NavigationManagerImpl serialization out of CRWSessionController.
>
> - Created CRWNavigationManagerStorage, which holds all the data that
> is persisted for a single NavigationManager. It conforms to NSCoding and
> is responsible for encoding sessions. A factory method for these objects
> as added to WebState's public interface.
> - Created NavigationManagerStorageBuilder, which contains functions
> to convert between NavigationManagers and
> CRWNavigationManagerStorage.
> - Changed the relationship between WebStateImpls and
> NavigationManagerImpls. Previously, WebStateImpls created empty
> NavigationManagerImpls and injected deserialized CRWSessionControllers
> into them. Now, WebStateImpls are passed serialized NavigationManagers
> upon construction when restoring state.
> - SessionWindowIOS's interface is updated to use NavigationManager
> serializations rather than WebStateImpls, and SessionWindowIOS clients in
> chrome// can use these to create WebStates using CreateParams.
>
> BUG=454984
>
> Review-Url: https://codereview.chromium.org/1360993002
> Cr-Commit-Position: refs/heads/master@{#446279}
> Committed: https://chromium.googlesource.com/chromium/src/+/be48752128d7ec4a5bd6d980157deb60dbb29548
TBR=eugenebut@chromium.org,kkhorimoto@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454984
Review-Url: https://codereview.chromium.org/2655253002
Cr-Commit-Position: refs/heads/master@{#446294}
Committed: https://chromium.googlesource.com/chromium/src/+/75cf0e280ec3d153cfafe7b20d9c0a860bd08c03
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|