Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2655223004: Remove duplicated "display: flow-root" test (Closed)

Created:
3 years, 10 months ago by Manuel Rego
Modified:
3 years, 10 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicated "display: flow-root" test The test for "display: flow-root" has been upstreamed into W3C csswg-test repository. With the last import of csswg-test in r446595 the test is now duplicated. This patch removes it from fast/block/float/. BUG=672508 Review-Url: https://codereview.chromium.org/2655223004 Cr-Commit-Position: refs/heads/master@{#446721} Committed: https://chromium.googlesource.com/chromium/src/+/b709759f51db1a4d86c0fef25a3301c7a9f4e44e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -108 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001-expected.html View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Manuel Rego
I guess the imported test doesn't need to be skipped for LayoutNG. The test is ...
3 years, 10 months ago (2017-01-27 09:04:20 UTC) #2
qyearsley
lgtm
3 years, 10 months ago (2017-01-27 16:04:59 UTC) #3
eae
LGTM
3 years, 10 months ago (2017-01-27 17:35:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655223004/1
3 years, 10 months ago (2017-01-27 17:38:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/352199)
3 years, 10 months ago (2017-01-27 17:49:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655223004/1
3 years, 10 months ago (2017-01-27 18:30:47 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 18:41:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b709759f51db1a4d86c0fef25a33...

Powered by Google App Engine
This is Rietveld 408576698